Adding reduce-kv to data.priority-map

78 views
Skip to first unread message

Mark Engelberg

unread,
Apr 10, 2018, 4:05:10 AM4/10/18
to clojure-dev
I just tried to build version 0.0.9 of data.priority-map, in which I added an implementation of the IKVReduce protocol for more efficient support of reduce-kv with priority maps.

Unfortunately, the test cases fail in the test matrix for Clojure versions 1.2.0, 1.2.1, 1.3.0, and 1.4.0.  It works for versions 1.5.0 and newer.

Can we remove versions 1.2.0 - 1.4.0 from the test matrix for data.priority-map so that this build will succeed?

Thanks,

Mark

Alex Miller

unread,
Apr 10, 2018, 7:48:40 AM4/10/18
to cloju...@googlegroups.com
Changed and kicked off a build of the project.
--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev...@googlegroups.com.
To post to this group, send email to cloju...@googlegroups.com.
Visit this group at https://groups.google.com/group/clojure-dev.
For more options, visit https://groups.google.com/d/optout.

Alex Miller

unread,
Apr 10, 2018, 8:49:23 AM4/10/18
to cloju...@googlegroups.com
Build failed, but looks like due to an actual test failure.

Mark Engelberg

unread,
Apr 10, 2018, 2:29:00 PM4/10/18
to clojure-dev
Thanks  That's the test failure that was appearing before, but the test-matrix only showed a problem in versions 1.2.0-1.4.0 (Build 333 of data.priority-map-test-matrix).
When I go to the data.priority-map-test-matrix build now, it shows no configurations at all any more in the test-matrix, so I can't see what version is failing in the overall build. Are all the configurations supposed to be gone?

On Tue, Apr 10, 2018 at 5:49 AM, Alex Miller <al...@puredanger.com> wrote:
Build failed, but looks like due to an actual test failure.

On Apr 10, 2018, at 6:48 AM, Alex Miller <al...@puredanger.com> wrote:

Changed and kicked off a build of the project.

On Apr 10, 2018, at 3:04 AM, Mark Engelberg <mark.en...@gmail.com> wrote:

I just tried to build version 0.0.9 of data.priority-map, in which I added an implementation of the IKVReduce protocol for more efficient support of reduce-kv with priority maps.

Unfortunately, the test cases fail in the test matrix for Clojure versions 1.2.0, 1.2.1, 1.3.0, and 1.4.0.  It works for versions 1.5.0 and newer.

Can we remove versions 1.2.0 - 1.4.0 from the test matrix for data.priority-map so that this build will succeed?

Thanks,

Mark

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev+unsubscribe@googlegroups.com.

To post to this group, send email to cloju...@googlegroups.com.
Visit this group at https://groups.google.com/group/clojure-dev.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev+unsubscribe@googlegroups.com.

Alex Miller

unread,
Apr 10, 2018, 2:54:30 PM4/10/18
to Clojure Dev

On Tuesday, April 10, 2018 at 1:29:00 PM UTC-5, puzzler wrote:
Thanks  That's the test failure that was appearing before, but the test-matrix only showed a problem in versions 1.2.0-1.4.0 (Build 333 of data.priority-map-test-matrix).

I think you're probably getting the default Clojure version in the main build, which is 1.2 iirc. 

To change the default Clojure build dependency add something like this to your pom.xml (usually best to use the minimum acceptable version):

  <properties>
    <clojure.version>1.5.0</clojure.version>
  </properties>

When I go to the data.priority-map-test-matrix build now, it shows no configurations at all any more in the test-matrix, so I can't see what version is failing in the overall build. Are all the configurations supposed to be gone?

The matrix is blank until it's built the first time (it's "new" since I just reloaded it). It hasn't built yet because the main build didn't successfully build. You can kick it off manually though, which I just did.

Alex Miller

unread,
Apr 10, 2018, 2:55:47 PM4/10/18
to Clojure Dev
Actually, must be something else going on with the matrix, I'll take a look at it.

Alex Miller

unread,
Apr 10, 2018, 2:58:51 PM4/10/18
to Clojure Dev
Ah, the problem is that 1.5.0 is not a build version we have configured on the build box as it was superseded due to the read eval stuff in 1.5.1. So I'm updating that. You should use this in your pom:

  <properties>
    <clojure.version>1.5.1</clojure.version>
  </properties>

Mark Engelberg

unread,
Apr 10, 2018, 3:51:36 PM4/10/18
to clojure-dev
Success!  Thank you.
Reply all
Reply to author
Forward
0 new messages