allow '/' as a protocol method name in cljs

[henry w]

Hi,

Although the following compiles in cljs (and so 'cljs.div//' exists), an error is thrown on calling the function. It works as expected in Clojure.


(ns cljs.div
(:refer-clojure :exclude [/]))

(defprotocol p
(/ [_]))

(extend-type
#?(:clj String :cljs string)
p
(/ [_] "result"))


; this throws
(/ "")

I've searched jira and not found an existing issue for this but please let me know if I've missed it.

Thanks,
Henry

[David Nolen]

Feel free to open a minor issue in JIRA. If you have a patch in mind, please attach it.

Thanks,

David

--
You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cloju...@googlegroups.com.
Visit this group at https://groups.google.com/group/clojure-dev.
For more options, visit https://groups.google.com/d/optout.

[henry w]

On Thursday, March 1, 2018 at 5:59:05 PM UTC, David Nolen wrote:
> Feel free to open a minor issue in JIRA. If you have a patch in mind, please attach it.
>
>
> Thanks,
> David
>
>
> On Wed, Feb 28, 2018 at 9:03 AM, henry w <henr...@gmail.com> wrote:
> Hi,
>
>
>
> Although the following compiles in cljs (and so 'cljs.div//' exists), an error is thrown on calling the function. It works as expected in Clojure.
>
>
>
>
>
> (ns cljs.div
>
>   (:refer-clojure :exclude [/]))
>
>
>
> (defprotocol p
>
>   (/ [_]))
>
>
>
> (extend-type
>
>   #?(:clj String :cljs string)
>
>   p
>
>   (/ [_] "result"))
>
>
>
>
>
> ; this throws
>
> (/ "")
>
>
>
> I've searched jira and not found an existing issue for this but please let me know if I've missed it.
>
>
>
> Thanks,
>
> Henry
>
>
>
> --
>
> You received this message because you are subscribed to the Google Groups "Clojure Dev" group.
>

> To unsubscribe from this group and stop receiving emails from it, send an email to clojure-dev...@googlegroups.com.

>
> To post to this group, send email to cloju...@googlegroups.com.
>
> Visit this group at https://groups.google.com/group/clojure-dev.
>
> For more options, visit https://groups.google.com/d/optout.

Will do, thanks

[henry w]

I've written up my findings so far, but as for a fix it'd be great to get an opinion on whether to start trying to do that in analysis or compilation

https://dev.clojure.org/jira/browse/CLJS-2589?focusedCommentId=48780#comment-48780 

Thanks,

Henry

[henry w]

I've submitted a patch.

Feedback welcome :-)

Thanks,

Henry