more clojure tests

2 views
Skip to first unread message

Mike Hinchey

unread,
Aug 4, 2009, 2:59:19 PM8/4/09
to cloju...@googlegroups.com
I've written a few unit tests for clojure.core.  Should I create a ticket with a patch?

Also, I found and fixed 2 problems with the ant task for running tests. One, ant should fail when the tests fail, not just print the report. Second, when the test target is used with compile (eg, ant all test), the report is not printed at all.  Would you like a ticket and patch for this?

-Mike

Rich Hickey

unread,
Aug 6, 2009, 8:23:01 AM8/6/09
to Clojure Dev


On Aug 4, 2:59 pm, Mike Hinchey <hinche...@gmail.com> wrote:
> I've written a few unit tests for clojure.core.  Should I create a ticket
> with a patch?
>

Sure, thanks!

> Also, I found and fixed 2 problems with the ant task for running tests. One,
> ant should fail when the tests fail, not just print the report. Second, when
> the test target is used with compile (eg, ant all test), the report is not
> printed at all.  Would you like a ticket and patch for this?
>

It seems ok to me, but I'm not doing anything automated on top of the
ant task. Is anyone, and could you chime in please?

Rich

Chas Emerick

unread,
Aug 6, 2009, 8:37:52 AM8/6/09
to cloju...@googlegroups.com

On Aug 6, 2009, at 8:23 AM, Rich Hickey wrote:

>> Also, I found and fixed 2 problems with the ant task for running
>> tests. One,
>> ant should fail when the tests fail, not just print the report.
>> Second, when
>> the test target is used with compile (eg, ant all test), the report
>> is not
>> printed at all. Would you like a ticket and patch for this?
>>
>
> It seems ok to me, but I'm not doing anything automated on top of the
> ant task. Is anyone, and could you chime in please?

Definitely +1 on those. I'm putting together plans to automatically
build clojure + contrib, and run all available tests within a hudson
environment, so these sort of things are important there. This is in
service of being able to base our own stuff against HEAD (or something
as close as possible to it) as much as possible.

- Chas

Mike Hinchey

unread,
Aug 8, 2009, 4:11:56 AM8/8/09
to cloju...@googlegroups.com
I submitted patches on #167 and #168.  Also included failonerror=true for the compile-clojure target so an error there doesn't end with "build successful".

-Mike
Reply all
Reply to author
Forward
0 new messages