Cleverhans 2.1 Release - Finalization

56 views
Skip to first unread message

Yash Sharma

unread,
Apr 12, 2018, 5:04:34 PM4/12/18
to cleverhans dev
Hi all, 

The Cleverhans authors are thinking of making a 2.1 release. 
Please post here any bugs that you feel ought to be fixed before the 2.1 release is tagged. 

Thank you. 

Ian Goodfellow

unread,
Apr 12, 2018, 5:39:02 PM4/12/18
to Yash Sharma, cleverhans dev
Just looking through the open issues list, I think we should probably fix:
just so that there aren't known, simple-to-fix bugs in the release.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/81c38fdc-76df-4c7c-8ef0-5cb6afe79307%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Alex Kurakin

unread,
Apr 12, 2018, 8:32:01 PM4/12/18
to Ian Goodfellow, Yash Sharma, cleverhans dev
Hi all,

There are two issues (unreported) which cause problems when running cleverhans in certain environments.
Both could be fixed by changing few lines of code. I'm planning to make PR with these changes tomorrow. It would be nice if these changes could be included into cleverhans 2.1

Alex

On Thu, Apr 12, 2018 at 2:39 PM Ian Goodfellow <goodfel...@gmail.com> wrote:
Just looking through the open issues list, I think we should probably fix:
just so that there aren't known, simple-to-fix bugs in the release.
On Thu, Apr 12, 2018 at 2:04 PM, Yash Sharma <yshar...@gmail.com> wrote:
Hi all, 

The Cleverhans authors are thinking of making a 2.1 release. 
Please post here any bugs that you feel ought to be fixed before the 2.1 release is tagged. 

Thank you. 

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/81c38fdc-76df-4c7c-8ef0-5cb6afe79307%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/CAPXn81pE4ucdK0rpD-ewyQWax_QUPei0pSydUYSCeStLJBQErQ%40mail.gmail.com.

Yash Sharma

unread,
Apr 23, 2018, 1:54:09 PM4/23/18
to cleverhans dev
So, are we ready for the 2.1 release? Should I send a pull request for the final contributor list?


On Thursday, April 12, 2018 at 8:32:01 PM UTC-4, Alex Kurakin wrote:
Hi all,

There are two issues (unreported) which cause problems when running cleverhans in certain environments.
Both could be fixed by changing few lines of code. I'm planning to make PR with these changes tomorrow. It would be nice if these changes could be included into cleverhans 2.1

Alex

On Thu, Apr 12, 2018 at 2:39 PM Ian Goodfellow <goodfel...@gmail.com> wrote:
Just looking through the open issues list, I think we should probably fix:
just so that there aren't known, simple-to-fix bugs in the release.
On Thu, Apr 12, 2018 at 2:04 PM, Yash Sharma <yshar...@gmail.com> wrote:
Hi all, 

The Cleverhans authors are thinking of making a 2.1 release. 
Please post here any bugs that you feel ought to be fixed before the 2.1 release is tagged. 

Thank you. 

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

Alex Kurakin

unread,
Apr 23, 2018, 1:58:40 PM4/23/18
to Yash Sharma, Nicolas Papernot, cleverhans dev
Looks like most of the issues were fixed.

One remaining open issue which Ian mentioned is this one: https://github.com/tensorflow/cleverhans/issues/372
however it already have PR merged, so I think we just need to confirm that issue is fixed.
Nicolas, you were last person commenting there, could you confirm whether it fixed or not?

On Mon, Apr 23, 2018 at 10:54 AM Yash Sharma <yshar...@gmail.com> wrote:
So, are we ready for the 2.1 release? Should I send a pull request for the final contributor list?

On Thursday, April 12, 2018 at 8:32:01 PM UTC-4, Alex Kurakin wrote:
Hi all,

There are two issues (unreported) which cause problems when running cleverhans in certain environments.
Both could be fixed by changing few lines of code. I'm planning to make PR with these changes tomorrow. It would be nice if these changes could be included into cleverhans 2.1

Alex

On Thu, Apr 12, 2018 at 2:39 PM Ian Goodfellow <goodfel...@gmail.com> wrote:
Just looking through the open issues list, I think we should probably fix:
just so that there aren't known, simple-to-fix bugs in the release.
On Thu, Apr 12, 2018 at 2:04 PM, Yash Sharma <yshar...@gmail.com> wrote:
Hi all, 

The Cleverhans authors are thinking of making a 2.1 release. 
Please post here any bugs that you feel ought to be fixed before the 2.1 release is tagged. 

Thank you. 

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/f2e4ef1a-b19a-47c7-a1ab-b65056f1faae%40googlegroups.com.

Nicolas Papernot

unread,
Apr 23, 2018, 2:46:03 PM4/23/18
to Alex Kurakin, Yash Sharma, cleverhans dev
Thanks Alex, yes the issue was addressed in the merged PR by adding a warning that the argument specifying the number of classes will become mandatory.

LGTM for a 2.1 release.

-N

On Mon, Apr 23, 2018 at 2:43 PM Nicolas Papernot <nic...@papernot.fr> wrote:
Thanks Alex, yes the issue was addressed in the merged PR by adding a warning that the argument specifying the number of classes will become mandatory.

LGTM for a 2.1 release.

-N

Yash Sharma

unread,
May 2, 2018, 3:23:02 PM5/2/18
to cleverhans dev
Pull request made for final contributor list (Build failed because of a problem with test_mnist_tutorial_keras_tf, please check)

Once the pull has been completed, can we do the 2.1 release?
-N

To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

Ian Goodfellow

unread,
May 2, 2018, 3:53:04 PM5/2/18
to Yash Sharma, cleverhans dev
Yeah, let's do the release once it's merged.

-N

To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/10c0c875-2bc4-4f7b-80f2-0a7189f52543%40googlegroups.com.

Ian Goodfellow

unread,
May 2, 2018, 6:42:22 PM5/2/18
to Yash Sharma, cleverhans dev
Anyone want to review this one-line PR? Should fix the build problem that's holding up the contributor list PR.

Yash Sharma

unread,
May 4, 2018, 5:15:52 AM5/4/18
to cleverhans dev
Thanks Nicolas for the merge. Let's do the release. Ian and Nicolas, are you handling that?
-N

To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.

Ian Goodfellow

unread,
May 4, 2018, 5:10:58 PM5/4/18
to Yash Sharma, cleverhans dev
No, I thought you were handling the release.
The next step is to update the arxiv paper: https://arxiv.org/e-print/1610.00768
(After downloading the file, rename it to end in ".tar.gz" and then open it)
It needs to be updated to have the new author list. When you have the file ready, send it to me and I'll upload it to arxiv.
After that, the README will need to be updated to point to the new arxiv paper, and we'll need a commit that sets the version string to '2.1.0' instead of the dev branch function call.

-N

To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverh...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-dev+unsubscribe@googlegroups.com.
To post to this group, send email to cleverhans-dev@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cleverhans-dev/b2ad850a-ed66-40a5-a6c0-43f6c66e2f38%40googlegroups.com.

Yash Sharma

unread,
May 4, 2018, 11:37:53 PM5/4/18
to Ian Goodfellow, cleverhans dev
(When I open the tar.gz the bibtex file isn't included)
Doesn't the paper need updating? Like the attacks and defense sections? Only FGSM, JSMA, and Adversarial training are described. 
Also, for authors, what should we do about those who have unknown affiliations (Zhi Li - 7 commits, Paul Hendricks - 3 commits) or even their names (Shuolongbj - 2 commits)?



Nicolas Papernot

unread,
May 5, 2018, 12:45:03 AM5/5/18
to Yash Sharma, Ian Goodfellow, cleverhans dev
Yes, it's very likely the report needs updating to include at least mention the attacks now included.

I created an issue to try and get some information on the missing affiliations 

-N

To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cleverhans-de...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "cleverhans dev" group.