serializable features

[Miller, Timothy]

I'm working on Issue-406 [1] to use serialized models for the libsvm-based tree kernel (rather than converting the model to text and then converting it right back). This is running into problems because the FeatureVector class is not serializable. (As a reminder, the tree kernel libsvm uses a branched version of libsvm with generic svm_node's instead of plain arrays). Is there any preference to keep the serialized interface away from FeatureVector's or can I make the change?

Thanks

Tim

[1] https://code.google.com/p/cleartk/issues/detail?id=406&sort=owner&colspec=ID%20Type%20Status%20Component%20Milestone%20Owner%20Summary

[Steven Bethard]

I think it's fine to make it Serializable. I don't see any
disadvantages to doing so.

Steve

> --
> You received this message because you are subscribed to the Google Groups
> "cleartk-developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cleartk-develop...@googlegroups.com.
> To post to this group, send email to cleartk-d...@googlegroups.com.
> Visit this group at http://groups.google.com/group/cleartk-developers.
> For more options, visit https://groups.google.com/d/optout.

[Miller, Timothy]

OK. I checked in a version of the fix without the serialization of FeatureVector but i will break that off next. I passed the tests for the modules i modified but was getting a failure on cleartk-ml test that seemed unrelated -- is that known to fail right now?

Failed tests:
MutualInformationTest.testMutualInformationFeatureSelection:135 expected:<Bag_Covered:[wolf]> but was:<Bag_Covered:[pig]>

Tim

________________________________________
From: cleartk-d...@googlegroups.com [cleartk-d...@googlegroups.com] on behalf of Steven Bethard [steven....@gmail.com]
Sent: Sunday, January 11, 2015 9:34 AM
To: cleartk-d...@googlegroups.com
Subject: Re: [ClearTK developers] serializable features

[Steven Bethard]

I'm not getting that failure with a current checkout. What platform are you on?

Steve

On Wed, Jan 14, 2015 at 6:40 AM, Miller, Timothy

[Miller, Timothy]

That was from Mac OS yosemite with java 1.8. I was running the junit
tests from within eclipse because I hadn't yet installed command line
maven. I can try again from the terminal once I get mvn installed.
Tim

[Steven Bethard]

Hmm. It passed for me on OS X Mavericks with java 1.7.0_45, but failed
with 1.8.0_25. Not sure what Java 8 changed, but something it's doing
is apparently causing that test to fail.

Steve

On Thu, Jan 15, 2015 at 10:47 AM, Miller, Timothy

[Majid Laali]

Hi, 

I just want to inform you that I have created a patch for this issue (different behavior of the test in Java 1.7 and 1.8) last week. Please check the issue 417 for more detail. Briefly, the problem roots on HashBasedTable used in MutualInformationStats. Please let me know if you need any further information.

Thanks,

Majid

>>>> email to cleartk-developers+unsub...@googlegroups.com.

>>>> To post to this group, send email to cleartk-d...@googlegroups.com.
>>>> Visit this group at http://groups.google.com/group/cleartk-developers.
>>>> For more options, visit https://groups.google.com/d/optout.
>>> --
>>> You received this message because you are subscribed to the Google Groups "cleartk-developers" group.

>>> To unsubscribe from this group and stop receiving emails from it, send an email to cleartk-developers+unsub...@googlegroups.com.

>>> To post to this group, send email to cleartk-d...@googlegroups.com.
>>> Visit this group at http://groups.google.com/group/cleartk-developers.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups "cleartk-developers" group.

>>> To unsubscribe from this group and stop receiving emails from it, send an email to cleartk-developers+unsub...@googlegroups.com.

>>> To post to this group, send email to cleartk-d...@googlegroups.com.
>>> Visit this group at http://groups.google.com/group/cleartk-developers.
>>> For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "cleartk-developers" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to cleartk-developers+unsub...@googlegroups.com.