Re: 'Mistakes' in Clean Code Episode 19 Part 1

[Uncle Bob]

Winner #3

[Sean Moir]

Yay!

On Thursday, 6 June 2013 10:43:06 UTC+1, Sean Moir wrote:

In Episode 19, Uncle Bob invites us to point out his - no doubt intentional - mistakes made while refactoring the code.

I have spotted a few - not sure if I should post them one at a time, all at once, or whether there is another route that I should have taken?

I will say that I think it violates the Single Responsibility Principle to allow the Invert Names class to be responsible for Honorifics and Post Nominals since this functionality could *change for different reasons* than the main Invert Names class itself e.g. for different cultures, or if new titles emerge.

I have a few other spots if you need them, or if this one doesn't qualify for the correct type of correction?

best regards

Sean