Adding a Riemann solver to clawpack/riemann/

[David Ketcheson]

This message is mainly directed to Aron, as I believe he is the most familiar with the issues in question.

I recently added a new Riemann solver; it was the first I've added since the changes to the install process for the python code.  I added the .f90 file in clawpack/riemann/src/ and modified the Makefile in clawpack/riemann/src/python/riemann.

However, on at least one system I've found that this doesn't cause the file to be compile on install.  Apparently now there is a list of Riemann solvers in clawpack/riemann/setup.py that supersedes the Makefile.

As far as I can tell, this is not documented anywhere, and in fact it's very confusing because we have a warning that prints a message about using the Makefile.

I think we should try to have just one list of the Riemann solvers that must be maintained, and delete the other lists if possible.  Do we still need the Makefile at all?

-David

[David Ketcheson]

I found one more file (with a lot of duplicated code) in clawpack/riemann/src/python/riemann/setup.py.  I had to add the solver to that one too in order to get things to work.  After we reduce the number of lists, we should document the process of adding a new Riemann solver.

-David

[Kyle Mandli]

Are you able to install just the Riemann package (apart from installing the entire Clawpack package)?  I have had the same problems but never tried to figure out what was going on since the Riemann package was never setup to install outside of the Clawpack meta-repository.

Kyle

--
You received this message because you are subscribed to the Google Groups "claw-dev" group.
To post to this group, send email to claw...@googlegroups.com.
To unsubscribe from this group, send email to claw-dev+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/claw-dev?hl=en.

[David Ketcheson]

Everything was installed fine except for the one new Riemann solver I added (traffic flow).  I've now fixed it, but I'd like to address the underlying issue of code duplication.