[PATCH] crypto: arm/ghash-ce - define fpu before fpu registers are referenced

0 views
Skip to first unread message

Stefan Agner

unread,
Mar 1, 2020, 6:37:26 PM3/1/20
to her...@gondor.apana.org.au, da...@davemloft.net, li...@armlinux.org.uk, manoj...@google.com, jia...@google.com, linux-...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, clang-bu...@googlegroups.com, Stefan Agner
Building ARMv7 with Clang's integrated assembler leads to errors such
as:
arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
t3l .req d16
^

Since no FPU has selected yet Clang considers d16 not a valid register.
Moving the FPU directive on-top allows Clang to parse the registers and
allows to successfully build this file with Clang's integrated assembler.

Signed-off-by: Stefan Agner <ste...@agner.ch>
---
arch/arm/crypto/ghash-ce-core.S | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/crypto/ghash-ce-core.S b/arch/arm/crypto/ghash-ce-core.S
index 534c9647726d..9f51e3fa4526 100644
--- a/arch/arm/crypto/ghash-ce-core.S
+++ b/arch/arm/crypto/ghash-ce-core.S
@@ -8,6 +8,9 @@
#include <linux/linkage.h>
#include <asm/assembler.h>

+ .arch armv8-a
+ .fpu crypto-neon-fp-armv8
+
SHASH .req q0
T1 .req q1
XL .req q2
@@ -88,8 +91,6 @@
T3_H .req d17

.text
- .arch armv8-a
- .fpu crypto-neon-fp-armv8

.macro __pmull_p64, rd, rn, rm, b1, b2, b3, b4
vmull.p64 \rd, \rn, \rm
--
2.25.1

Nick Desaulniers

unread,
Mar 3, 2020, 5:20:16 PM3/3/20
to Stefan Agner, Herbert Xu, David S. Miller, Russell King, Manoj Gupta, Jian Cai, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, Linux ARM, LKML, clang-built-linux, Ard.Bie...@arm.com
On Sun, Mar 1, 2020 at 3:37 PM Stefan Agner <ste...@agner.ch> wrote:
>
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.

Certainly a side effect of having a single pass assembler...This does
fix what otherwise looks like a slew of errors for us, thanks for the
patch.
Reviewed-by: Nick Desaulniers <ndesau...@google.com>
Tested-by: Nick Desaulniers <ndesau...@google.com>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-li...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/c41cc67321d0b366e356440e6dbc9eceb1babfe4.1583105749.git.stefan%40agner.ch.



--
Thanks,
~Nick Desaulniers

Ard Biesheuvel

unread,
Mar 4, 2020, 2:40:06 AM3/4/20
to Stefan Agner, Herbert Xu, David S. Miller, Russell King, Manoj Gupta, Jian Cai, open list:HARDWARE RANDOM NUMBER GENERATOR CORE, linux-arm-kernel, Linux Kernel Mailing List, clang-built-linux
On Mon, 2 Mar 2020 at 00:37, Stefan Agner <ste...@agner.ch> wrote:
>
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.
>
> Signed-off-by: Stefan Agner <ste...@agner.ch>

Acked-by: Ard Biesheuvel <ar...@kernel.org>

Herbert Xu

unread,
Mar 5, 2020, 8:53:05 PM3/5/20
to Stefan Agner, da...@davemloft.net, li...@armlinux.org.uk, manoj...@google.com, jia...@google.com, linux-...@vger.kernel.org, linux-ar...@lists.infradead.org, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
On Mon, Mar 02, 2020 at 12:37:14AM +0100, Stefan Agner wrote:
> Building ARMv7 with Clang's integrated assembler leads to errors such
> as:
> arch/arm/crypto/ghash-ce-core.S:34:11: error: register name expected
> t3l .req d16
> ^
>
> Since no FPU has selected yet Clang considers d16 not a valid register.
> Moving the FPU directive on-top allows Clang to parse the registers and
> allows to successfully build this file with Clang's integrated assembler.
>
> Signed-off-by: Stefan Agner <ste...@agner.ch>
> ---
> arch/arm/crypto/ghash-ce-core.S | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <her...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Reply all
Reply to author
Forward
0 new messages