Re: [net-next,v8] net: stmmac: optimize check in ops '.begin'

[kernel test robot]

Hi Hao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on ipvs/master]
[also build test ERROR on linus/master v5.14-rc4 next-20210802]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Hao-Chen/net-stmmac-optimize-check-in-ops-begin/20210803-104151
base: https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: x86_64-randconfig-a003-20210802 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a618eda31260a301aadf7987885767f905c5320a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hao-Chen/net-stmmac-optimize-check-in-ops-begin/20210803-104151
git checkout a618eda31260a301aadf7987885767f905c5320a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All errors (new ones prefixed by >>):

drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:378:7: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause;
^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:35: error: passing 'struct device' to parameter of incompatible type 'struct device *'; take the address with &
return pm_runtime_resume_and_get(dev->dev);
^~~~~~~~
&
include/linux/pm_runtime.h:400:60: note: passing argument to parameter 'dev' here
static inline int pm_runtime_resume_and_get(struct device *dev)
^
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:421:17: error: passing 'struct device' to parameter of incompatible type 'struct device *'; take the address with &
pm_runtime_put(dev->dev);
^~~~~~~~
&
include/linux/pm_runtime.h:420:49: note: passing argument to parameter 'dev' here
static inline int pm_runtime_put(struct device *dev)
^
1 warning and 2 errors generated.


vim +416 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

413
414 static int stmmac_ethtool_begin(struct net_device *dev)
415 {
> 416 return pm_runtime_resume_and_get(dev->dev);
417 }
418

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuil...@lists.01.org