[PATCH 5.10 1/9] kprobes/x86: Fix fall-through warnings for Clang

2 views
Skip to first unread message

Li Huafei

unread,
Jul 5, 2023, 2:47:43 AM7/5/23
to sta...@vger.kernel.org, gre...@linuxfoundation.org, mhir...@kernel.org, tg...@linutronix.de, mi...@redhat.com, b...@alien8.de, x...@kernel.org, h...@zytor.com, sas...@kernel.org, pet...@infradead.org, linux-...@vger.kernel.org, xuku...@huawei.com, natecha...@gmail.com, ndesau...@google.com, ros...@goodmis.org, weiyo...@huawei.com, gusta...@kernel.org, na...@vmware.com, la...@linux.alibaba.com, clang-bu...@googlegroups.com, lihu...@huawei.com
From: "Gustavo A. R. Silva" <gusta...@kernel.org>

[ Upstream commit e689b300c99ca2dd80d3f662e19499bba27cda09 ]

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Signed-off-by: Gustavo A. R. Silva <gusta...@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Li Huafei <lihu...@huawei.com>
---
arch/x86/kernel/kprobes/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index 5de757099186..ed9a4fb87168 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -880,6 +880,7 @@ static void resume_execution(struct kprobe *p, struct pt_regs *regs,
p->ainsn.boostable = true;
goto no_change;
}
+ break;
default:
break;
}
--
2.17.1

gre...@linuxfoundation.org

unread,
Aug 4, 2023, 5:56:40 AM8/4/23
to b...@alien8.de, clang-bu...@googlegroups.com, gre...@linuxfoundation.org, gusta...@kernel.org, h...@zytor.com, la...@linux.alibaba.com, lihu...@huawei.com, mhir...@kernel.org, mi...@redhat.com, na...@vmware.com, natecha...@gmail.com, ndesau...@google.com, pet...@infradead.org, ros...@goodmis.org, sas...@kernel.org, tg...@linutronix.de, weiyo...@huawei.com, x...@kernel.org, xuku...@huawei.com, stable-...@vger.kernel.org

This is a note to let you know that I've just added the patch titled

kprobes/x86: Fix fall-through warnings for Clang

to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
kprobes-x86-fix-fall-through-warnings-for-clang.patch
and it can be found in the queue-5.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <sta...@vger.kernel.org> know about it.


From stable...@vger.kernel.org Wed Jul 5 08:47:50 2023
From: Li Huafei <lihu...@huawei.com>
Date: Wed, 5 Jul 2023 14:46:45 +0800
Subject: kprobes/x86: Fix fall-through warnings for Clang
To: <sta...@vger.kernel.org>
Cc: <gre...@linuxfoundation.org>, <mhir...@kernel.org>, <tg...@linutronix.de>, <mi...@redhat.com>, <b...@alien8.de>, <x...@kernel.org>, <h...@zytor.com>, <sas...@kernel.org>, <pet...@infradead.org>, <linux-...@vger.kernel.org>, <xuku...@huawei.com>, <natecha...@gmail.com>, <ndesau...@google.com>, <ros...@goodmis.org>, <weiyo...@huawei.com>, <gusta...@kernel.org>, <na...@vmware.com>, <la...@linux.alibaba.com>, <clang-bu...@googlegroups.com>, <lihu...@huawei.com>
Message-ID: <20230705064653.2...@huawei.com>

From: "Gustavo A. R. Silva" <gusta...@kernel.org>

[ Upstream commit e689b300c99ca2dd80d3f662e19499bba27cda09 ]

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.

Signed-off-by: Gustavo A. R. Silva <gusta...@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Li Huafei <lihu...@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
arch/x86/kernel/kprobes/core.c | 1 +
1 file changed, 1 insertion(+)

--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -880,6 +880,7 @@ static void resume_execution(struct kpro
p->ainsn.boostable = true;
goto no_change;
}
+ break;
default:
break;
}


Patches currently in stable-queue which might be from stable...@vger.kernel.org are

queue-5.10/x86-kprobes-update-kcb-status-flag-after-singlestepping.patch
queue-5.10/x86-kprobes-fix-to-identify-indirect-jmp-and-others-using-range-case.patch
queue-5.10/x86-kprobes-fix-jng-jnle-emulation.patch
queue-5.10/x86-kprobes-retrieve-correct-opcode-for-group-instruction.patch
queue-5.10/x86-kprobes-use-int3-instead-of-debug-trap-for-single-step.patch
queue-5.10/x86-kprobes-do-not-decode-opcode-in-resume_execution.patch
queue-5.10/x86-kprobes-identify-far-indirect-jmp-correctly.patch
queue-5.10/kprobes-x86-fix-fall-through-warnings-for-clang.patch
queue-5.10/x86-kprobes-move-inline-to-the-beginning-of-the-kprobe_is_ss-declaration.patch
Reply all
Reply to author
Forward
0 new messages