[PATCH v29 01/11] dt-bindings: arm: mediatek: mmsys: add vdosys1 compatible for MT8195

[Nancy.Lin]

Add vdosys1 mmsys compatible for MT8195 platform.

For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding to
2 different power domains, different clock drivers and different
mediatek-drm drivers.

Signed-off-by: Nancy.Lin <nanc...@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfra...@collabora.com>
---
.../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
index 0711f1834fbd..242ce5a69432 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml
@@ -52,6 +52,10 @@ properties:
- const: mediatek,mt8195-mmsys
- const: syscon

+ - items:
+ - const: mediatek,mt8195-vdosys1
+ - const: syscon
+
reg:
maxItems: 1

--
2.18.0

[Krzysztof Kozlowski]

This should be part of first enum. Don't create redundant entries.

Best regards,
Krzysztof

[Nancy Lin (林欣螢)]

Dear Krzysztof,

Thanks for the review.

On Tue, 2023-01-10 at 11:50 +0100, Krzysztof Kozlowski wrote:
> On 27/12/2022 09:04, Nancy.Lin wrote:
> > Add vdosys1 mmsys compatible for MT8195 platform.
> > 
> > For MT8195, VDOSYS0 and VDOSYS1 are 2 display HW pipelines binding
> > to
> > 2 different power domains, different clock drivers and different
> > mediatek-drm drivers.
> > 
> > Signed-off-by: Nancy.Lin <nanc...@mediatek.com>
> > Reviewed-by: Nícolas F. R. A. Prado <nfra...@collabora.com>
> > ---
> >  .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml      | 4
> > ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > index 0711f1834fbd..242ce5a69432 100644
> > ---
> > a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yam
> > l
> > @@ -52,6 +52,10 @@ properties:
> >            - const: mediatek,mt8195-mmsys
> >            - const: syscon
> >  
> > +      - items:
> > +          - const: mediatek,mt8195-vdosys1
> 
> This should be part of first enum. Don't create redundant entries.
> 
> Best regards,
> Krzysztof

OK, I will modify as following:

@@ -33,6 +33,7 @@ properties:
               - mediatek,mt8186-mmsys
               - mediatek,mt8188-vdosys0
               - mediatek,mt8192-mmsys
+              - mediatek,mt8195-vdosys1
               - mediatek,mt8365-mmsys
           - const: syscon

Best,
Nancy
> 

************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any 
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be 
conveyed only to the designated recipient(s). Any use, dissemination, 
distribution, printing, retaining or copying of this e-mail (including its 
attachments) by unintended recipient(s) is strictly prohibited and may 
be unlawful. If you are not an intended recipient of this e-mail, or believe 
that you have received this e-mail in error, please notify the sender 
immediately (by replying to this e-mail), delete any and all copies of 
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!