[PATCH] scripts: switch some more scripts explicitly to Python 3

6 views
Skip to first unread message

Masahiro Yamada

unread,
Jan 31, 2021, 8:09:16 PM1/31/21
to linux-...@vger.kernel.org, linu...@vger.kernel.org, Masahiro Yamada, Greg Kroah-Hartman, Nathan Chancellor, Nick Desaulniers, Thomas Gleixner, clang-bu...@googlegroups.com, linux-...@vger.kernel.org, linux...@vger.kernel.org
For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
to Python 3"), switch some more scripts, which I tested and confirmed
working on Python 3.

Signed-off-by: Masahiro Yamada <masa...@kernel.org>
---

scripts/clang-tools/gen_compile_commands.py | 2 +-
scripts/clang-tools/run-clang-tools.py | 2 +-
scripts/spdxcheck.py | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/clang-tools/gen_compile_commands.py b/scripts/clang-tools/gen_compile_commands.py
index 19963708bcf8..8ddb5d099029 100755
--- a/scripts/clang-tools/gen_compile_commands.py
+++ b/scripts/clang-tools/gen_compile_commands.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0
#
# Copyright (C) Google LLC, 2018
diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
index fa7655c7cec0..f754415af398 100755
--- a/scripts/clang-tools/run-clang-tools.py
+++ b/scripts/clang-tools/run-clang-tools.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0
#
# Copyright (C) Google LLC, 2020
diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
index bc87200f9c7c..cbdb5c83c08f 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# SPDX-License-Identifier: GPL-2.0
# Copyright Thomas Gleixner <tg...@linutronix.de>

--
2.27.0

Nathan Chancellor

unread,
Jan 31, 2021, 8:33:28 PM1/31/21
to Masahiro Yamada, linux-...@vger.kernel.org, linu...@vger.kernel.org, Greg Kroah-Hartman, Nathan Chancellor, Nick Desaulniers, Thomas Gleixner, clang-bu...@googlegroups.com, linux-...@vger.kernel.org, linux...@vger.kernel.org
On Mon, Feb 01, 2021 at 10:08:18AM +0900, Masahiro Yamada wrote:
> For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
> to Python 3"), switch some more scripts, which I tested and confirmed
> working on Python 3.
>
> Signed-off-by: Masahiro Yamada <masa...@kernel.org>

Acked-by: Nathan Chancellor <nat...@kernel.org>

Nick Desaulniers

unread,
Feb 1, 2021, 1:28:18 PM2/1/21
to Masahiro Yamada, Linux Kbuild mailing list, Linux Doc Mailing List, Greg Kroah-Hartman, Nathan Chancellor, Thomas Gleixner, clang-built-linux, LKML, linux...@vger.kernel.org
On Sun, Jan 31, 2021 at 5:08 PM Masahiro Yamada <masa...@kernel.org> wrote:
>
> For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
> to Python 3"), switch some more scripts, which I tested and confirmed
> working on Python 3.
>
> Signed-off-by: Masahiro Yamada <masa...@kernel.org>

Thanks for the patch. It's time to move on from Python 2.

It looks like there's already a patch in -next for scripts/spdxcheck.py.
("spdxcheck.py: Use Python 3") by Bert Vermeulen.
https://lore.kernel.org/r/20210121085412...@biot.com

What about:
scripts/tracing/draw_functrace.py
scripts/show_delta
scripts/jobserver-exec

Or do those need additional source level changes?
--
Thanks,
~Nick Desaulniers

Masahiro Yamada

unread,
Feb 2, 2021, 1:10:33 AM2/2/21
to Nick Desaulniers, Linux Kbuild mailing list, Linux Doc Mailing List, Greg Kroah-Hartman, Nathan Chancellor, Thomas Gleixner, clang-built-linux, LKML, linux...@vger.kernel.org
On Tue, Feb 2, 2021 at 3:28 AM Nick Desaulniers <ndesau...@google.com> wrote:
>
> On Sun, Jan 31, 2021 at 5:08 PM Masahiro Yamada <masa...@kernel.org> wrote:
> >
> > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
> > to Python 3"), switch some more scripts, which I tested and confirmed
> > working on Python 3.
> >
> > Signed-off-by: Masahiro Yamada <masa...@kernel.org>
>
> Thanks for the patch. It's time to move on from Python 2.
>
> It looks like there's already a patch in -next for scripts/spdxcheck.py.
> ("spdxcheck.py: Use Python 3") by Bert Vermeulen.
> https://lore.kernel.org/r/20210121085412...@biot.com

OK, I dropped the spdxcheck.py change in v2.



> What about:
> scripts/tracing/draw_functrace.py
> scripts/show_delta
> scripts/jobserver-exec
>
> Or do those need additional source level changes?


I touched jobserver-exec in this patch:

https://patchwork.kernel.org/project/linux-kbuild/patch/20210201010024.6...@kernel.org/


I have not tested draw_functrac.py or show_delta.
--
Best Regards
Masahiro Yamada

Sedat Dilek

unread,
Feb 2, 2021, 1:55:17 AM2/2/21
to Masahiro Yamada, Nick Desaulniers, Linux Kbuild mailing list, Linux Doc Mailing List, Greg Kroah-Hartman, Nathan Chancellor, Thomas Gleixner, clang-built-linux, LKML, linux...@vger.kernel.org
On Tue, Feb 2, 2021 at 7:10 AM Masahiro Yamada <masa...@kernel.org> wrote:
>
> On Tue, Feb 2, 2021 at 3:28 AM Nick Desaulniers <ndesau...@google.com> wrote:
> >
> > On Sun, Jan 31, 2021 at 5:08 PM Masahiro Yamada <masa...@kernel.org> wrote:
> > >
> > > For the same reason as commit 51839e29cb59 ("scripts: switch explicitly
> > > to Python 3"), switch some more scripts, which I tested and confirmed
> > > working on Python 3.
> > >
> > > Signed-off-by: Masahiro Yamada <masa...@kernel.org>
> >
> > Thanks for the patch. It's time to move on from Python 2.
> >
> > It looks like there's already a patch in -next for scripts/spdxcheck.py.
> > ("spdxcheck.py: Use Python 3") by Bert Vermeulen.
> > https://lore.kernel.org/r/20210121085412...@biot.com
>
> OK, I dropped the spdxcheck.py change in v2.
>
>
>
> > What about:
> > scripts/tracing/draw_functrace.py
> > scripts/show_delta
> > scripts/jobserver-exec
> >
> > Or do those need additional source level changes?
>
>
> I touched jobserver-exec in this patch:
>
> https://patchwork.kernel.org/project/linux-kbuild/patch/20210201010024.6...@kernel.org/
>
>
> I have not tested draw_functrac.py or show_delta.
>

As Debian/testing - upcoming bullseye release - has moved to python3.9
(3.9.1-3) as default I am interested in the kbuild transition to
python3.

Is it possible to have a Git branch in kbuild.git especially for this
transition?

Honestly; I lost a bit the track of all kbuild/python3 patches.

Thanks.

- Sedat -
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-li...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/CAK7LNATSna9f8cd5Lm%3Dzx2vfJzk%3DWUnAUkA8V593O304zTx%3DvQ%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages