[PATCH] fs/ntfs3: Remove unused variable cnt in ntfs_security_init()

2 views
Skip to first unread message

Nathan Chancellor

unread,
Aug 16, 2021, 3:30:58 PM8/16/21
to Konstantin Komarov, nt...@lists.linux.dev, linux-...@vger.kernel.org, clang-bu...@googlegroups.com, Nathan Chancellor
Clang warns:

fs/ntfs3/fsntfs.c:1874:9: warning: variable 'cnt' set but not used
[-Wunused-but-set-variable]
size_t cnt, off;
^
1 warning generated.

It is indeed unused so remove it.

Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
Signed-off-by: Nathan Chancellor <nat...@kernel.org>
---
fs/ntfs3/fsntfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/ntfs3/fsntfs.c b/fs/ntfs3/fsntfs.c
index 92140050fb6c..c6599c514acf 100644
--- a/fs/ntfs3/fsntfs.c
+++ b/fs/ntfs3/fsntfs.c
@@ -1871,7 +1871,7 @@ int ntfs_security_init(struct ntfs_sb_info *sbi)
struct ATTRIB *attr;
struct ATTR_LIST_ENTRY *le;
u64 sds_size;
- size_t cnt, off;
+ size_t off;
struct NTFS_DE *ne;
struct NTFS_DE_SII *sii_e;
struct ntfs_fnd *fnd_sii = NULL;
@@ -1946,7 +1946,6 @@ int ntfs_security_init(struct ntfs_sb_info *sbi)
sbi->security.next_off =
Quad2Align(sds_size - SecurityDescriptorsBlockSize);

- cnt = 0;
off = 0;
ne = NULL;

@@ -1964,8 +1963,6 @@ int ntfs_security_init(struct ntfs_sb_info *sbi)
next_id = le32_to_cpu(sii_e->sec_id) + 1;
if (next_id >= sbi->security.next_id)
sbi->security.next_id = next_id;
-
- cnt += 1;
}

sbi->security.ni = ni;

base-commit: 96b18047a7172037ff4206720f4e889670030b41
--
2.33.0.rc2

Nick Desaulniers

unread,
Aug 16, 2021, 5:56:24 PM8/16/21
to Nathan Chancellor, Konstantin Komarov, nt...@lists.linux.dev, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
On Mon, Aug 16, 2021 at 12:30 PM Nathan Chancellor <nat...@kernel.org> wrote:
>
> Clang warns:
>
> fs/ntfs3/fsntfs.c:1874:9: warning: variable 'cnt' set but not used
> [-Wunused-but-set-variable]
> size_t cnt, off;
> ^
> 1 warning generated.
>
> It is indeed unused so remove it.
>
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")

I went back to the original patches to see if this was ever used;
since v2 (when the ntfs3 driver was split up) it was not. I triple
checked the v1 as well.
v2: https://lore.kernel.org/lkml/caddbe41eaef4622...@paragon-software.com/
v1: https://dl.paragon-software.com/ntfs3/ntfs3.patch
I don't think there's a logic error here.

Reviewed-by: Nick Desaulniers <ndesau...@google.com>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-li...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20210816193041.1164125-1-nathan%40kernel.org.



--
Thanks,
~Nick Desaulniers

Kari Argillander

unread,
Aug 16, 2021, 7:36:09 PM8/16/21
to Nathan Chancellor, Konstantin Komarov, Nick Desaulniers, nt...@lists.linux.dev, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
On Mon, Aug 16, 2021 at 12:30:41PM -0700, Nathan Chancellor wrote:
> Clang warns:
>
> fs/ntfs3/fsntfs.c:1874:9: warning: variable 'cnt' set but not used
> [-Wunused-but-set-variable]
> size_t cnt, off;
> ^
> 1 warning generated.
>
> It is indeed unused so remove it.
>
> Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")
> Signed-off-by: Nathan Chancellor <nat...@kernel.org>

Looks like it was used for debugging or way before index_find_raw()
needed hint or something. So this should be ok.

Reviewed-by: Kari Argillander <kari.arg...@gmail.com>

Konstantin Komarov

unread,
Aug 27, 2021, 12:12:33 PM8/27/21
to Nathan Chancellor, nt...@lists.linux.dev, linux-...@vger.kernel.org, clang-bu...@googlegroups.com
> From: Nathan Chancellor <nat...@kernel.org>
> Sent: Monday, August 16, 2021 10:31 PM
> To: Konstantin Komarov <almaz.ale...@paragon-software.com>
> Cc: nt...@lists.linux.dev; linux-...@vger.kernel.org; clang-bu...@googlegroups.com; Nathan Chancellor
> <nat...@kernel.org>
> Subject: [PATCH] fs/ntfs3: Remove unused variable cnt in ntfs_security_init()
Hi Nathan! Thanks for your contribution - applied.

Best regards.
Reply all
Reply to author
Forward
0 new messages