[CKEditor Dev] #16865: Fonts setting should not be toggling options.
CKEditor
-------------------+---------------------------
Reporter: zeron | Owner:
Type: Bug | Status: new
Priority: Normal | Component: Core : Styles
Version: 4.5.0 | Keywords:
-------------------+---------------------------
== Steps to reproduce ==
1. Change the font size for the first time it works correctly.
2. But if select the same font size again, it will revert back to the
original font size. The same for font style.
3. This behavior doesn't conform to other main editors, and could bring
problems.
== Expected result ==
Please prevent revert font back to original font if select same font
again.
== Actual result ==
Resetting the font to original font if select font again.
== Other details (browser, OS, CKEditor version, installed plugins) ==
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: new
Component: Core : Styles | Version: 4.5.0
----------------------------+-------------------
Comment (by zeron):
Besides inconformity to user habit, below is a known problem case.
- When I have some existing text and I paste additional paragraphs after
it, now selecting one font and style for all text only works the second
time, because for the first selecting it just resets the previous text to
default, the pasted text remains unchanged.
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:1>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
Resolution: | Keywords:
----------------------------+-----------------------
Changes (by j.swiderski):
* status: new => confirmed
* version: 4.5.0 => 4.0
Comment:
It has been working like that even in CKEditor 3.x. The benefit of such
approach is that you can simply click into area with a given font, select
font from the list to remove that font from whole area.
The only problem which I see here, is the one you have mentioned in
comment:1. We should be doing like MS Word does - when there is more than
one font selected or there is "font text font" in selection, we should not
auto highlight the font in dropdown.
Probably also some extra fixes will be needed to remove all nested fonts
from selection and apply new one outside.
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:2>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
Resolution: | Keywords:
----------------------------+-----------------------
Comment (by j.swiderski):
> But if select the same font size again, it will revert back to the
original font size. The same for font style.
Even MS Word does that. In my opinion CKEditor is very intuitive and
rather won't be changed.
[[BR]]
[[BR]]
> This behavior doesn't conform to other main editors, and could bring
problems.
Could you provide an example of such editor?
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:3>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: closed
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
----------------------------+--------------------
Changes (by j.swiderski):
* status: confirmed => closed
* resolution: => duplicate
Comment:
It turns out this is a duplicate of #13553
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:3>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: reopened
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
----------------------------+----------------------
Changes (by m.lewandowski):
* status: closed => reopened
* resolution: duplicate =>
Comment:
@j.swiderski these are two different issues.
Issue #13553 says about dropdown in case of selection that is has a
different value at the beginning and the end of selection, e.g. two
different fonts.
This issue however is related to the fact that once having given value in
a dropdown, say X, if you pick X again the feature will remove the style
from editor, while here OP expects the option to be preserved.
-----
Now, the current solution means like simple bold/underline features,
meaning that if you press it while being active, it will remove the style.
It works, but as mentioned this behavior is not interoperable with other
editors.
I agree that this change make sense for a better conformance with a common
editing experience. However it's a UX change that should be delivered with
a major release.
Note that this has more implications: how one should remove font size
markup? It requires to add something like `<unset>` position in the
dropdown, which is also not an ideal solution.
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:4>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
Resolution: | Keywords:
Changes (by j.swiderski):
* status: reopened => confirmed
Comment:
@m.lewandowski you are right I got too quick closing this one.
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:5>
CKEditor
Reporter: zeron | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: Core : Styles | Version: 4.0
Resolution: | Keywords:
----------------------------+-----------------------
Comment (by m.lewandowski):
Meanwhile I have reported the issue in our GitHub so it can be discussed
there. I made it a feature request though, as it's not a bug.
--
Ticket URL: <http://dev.ckeditor.com/ticket/16865#comment:6>