[CKEditor Dev] #10453: Keystrokes don't work for custom plugins

[CKEditor]

#10453: Keystrokes don't work for custom plugins
-------------------------------+----------------------
Reporter: j.swiderski | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: Core : Keystrokes | Version: 4.0 Beta
Keywords: |
-------------------------------+----------------------
This is the second time I encounter this problem. User has sent me his
custom plugin for v3. I have changed it to work with v4 but for some
reason keystroke checks that worked in v3 don't work anymore in v4.

To reproduce:
1. Use below code in replaebycode sample
{{{
CKEDITOR.replace( 'editor1', {
extraPlugins : 'en_nbsp'
});
}}}
2. Copy attached plugin folder for v4 and paste it into plugins folder.
3. Load page and try to insert   with Ctrl+space

Either I have missed something simple or there is a problem in editor. Any
explanations are welcome.

NOTE: There is also feature #8619 - perhaps it could be implemented while
fixing this one.

--
Ticket URL: <http://dev.ckeditor.com/ticket/10453>
CKEditor <http://ckeditor.com/>
The text editor for the Internet

[CKEditor]

#10453: Keystrokes don't work for custom plugins

--------------------------------+-----------------------
Reporter: j.swiderski | Owner:
Type: Bug | Status: confirmed

Priority: Normal | Milestone:
Component: Core : Keystrokes | Version: 4.0 Beta

Resolution: | Keywords:
--------------------------------+-----------------------
Changes (by j.swiderski):

* status: new => confirmed

--
Ticket URL: <http://dev.ckeditor.com/ticket/10453#comment:1>

[CKEditor]

#10453: Keystrokes don't work for custom plugins

--------------------------------+----------------------
Reporter: j.swiderski | Owner:
Type: Bug | Status: closed

Priority: Normal | Milestone:
Component: Core : Keystrokes | Version: 4.0 Beta

Resolution: invalid | Keywords:
--------------------------------+----------------------
Changes (by Reinmar):

* status: confirmed => closed
* resolution: => invalid

Comment:

The en_nbsp plugin from v4 works for me perfectly fine on FF and Chrome
after one change - there should be:

{{{
ev.data.preventDefault();
}}}

Version from v3.zip works too after removing:

{{{
requires : [ 'keystrokes' ],
}}}

There's no such plugin in v4.

--
Ticket URL: <http://dev.ckeditor.com/ticket/10453#comment:2>

[CKEditor]

#10453: Keystrokes don't work for custom plugins

--------------------------------+----------------------
Reporter: j.swiderski | Owner:
Type: Bug | Status: closed

Priority: Normal | Milestone:
Component: Core : Keystrokes | Version: 4.0 Beta

Resolution: invalid | Keywords:
--------------------------------+----------------------

Comment (by j.swiderski):

You are right I have added {{{ev.data.preventDefault();}}} and it works
perfectly.

I'm not sure why hasn't it worked before as even after removing this line
spaces are still inserted.

I have uploaded working plugin sample for v4.

--
Ticket URL: <http://dev.ckeditor.com/ticket/10453#comment:3>