[CKEditor Dev] #6161: Autogrow plugin should resize on instanceReady too.
CKEditor
---------------------+------------------------------------------------------
Reporter: bronson | Type: Bug
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
Keywords: |
---------------------+------------------------------------------------------
The autogrow plugin should resize the editor when starting up too.
Otherwise there's a good chance that the editor size will jump when you
first click on it. The patch is trivial:
{{{
--- a/public/app/ckeditor/_source/plugins/autogrow/plugin.js
+++ b/public/app/ckeditor/_source/plugins/autogrow/plugin.js
@@ -37,7 +37,7 @@ For licensing, see LICENSE.html or
http://ckeditor.com/license
{
init : function( editor )
{
- for ( var eventName in { contentDom:1, key:1,
selectionChange:1, insertElement:1 } )
+ for ( var eventName in { instanceReady:1, contentDom:1, key:1,
selectionChange:1, insertElement:1 } )
{
editor.on( eventName, function( evt )
{
}}}
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161>
CKEditor <http://ckeditor.com/>
The text editor for Internet
CKEditor
---------------------+------------------------------------------------------
Reporter: bronson | Type: Bug
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
Keywords: |
---------------------+------------------------------------------------------
Comment(by bronson):
I just noticed that contentDom is probably supposed to handle this.
All I can say is, on Firefox 3.6, resizing only contentDom causes the edit
area to come up in its original size. Then, when you click or keypress,
it pops to the right size. Resizing on instanceReady brings it up the
correct size.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:1>
CKEditor
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
----------------------+-----------------------------------------------------
Changes (by comp615):
* keywords: => HasPatch
Comment:
I second this motion. I just attached the exact change you made as a patch
file for easier access initally, then I had another thought looking at the
patch, turns out I was right. It should also fire on the mode event.
To test this bug, if you make some very long source code and copy
it...then empty the editor in WYSIWYG, then go to source, paste, and hit
source. The editor should grow, but again doesn't until you click it.
Finally, the editor doesn't grow or shrink at all in Source mode. I see
that this is intentionally so in the code, as removing this causes an
error, but would it theoretically be possible to have that functionality?
I'm not sure if that would make it more or less useful (As source code is
always longer it would be constantly growing and shrinking)
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:2>
CKEditor
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
----------------------+-----------------------------------------------------
Comment(by comp615):
Perhaps it should also resize when you resize an object? In theory if you
sized an image below the editor, the editor should grow accordingly when
done. I'm not sure how to put this in, resize or resizestart? Perhaps
someone else knows better if this is possible.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:3>
CKEditor
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
----------------------+-----------------------------------------------------
Changes (by tigris):
* cc: fckeditor@… (added)
Comment:
I tried this patch but it doesn't seem to fix it for me? I am running 3.4
stable though, not the nightly build or anything.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:4>
CKEditor
Status: new | Priority: Normal
Component: General | Version: 3.4.1 (SVN - trunk)
----------------------+-----------------------------------------------------
Comment(by tigris):
Ignore me. It works fine. I was calling CKEDITOR.replace() twice which
confused autogrow instanceReady event.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:5>
CKEditor
Status: new | Priority: Normal
Component: General | Version: 3.4.1
----------------------+-----------------------------------------------------
Comment(by dinu):
I second this make it into the trunk. It would be awfully nice if the
autogrow were more intimately connected to the editor though; for
instance, when replacing a div, the editor is first sized to config.height
then autogrow'ed... if the div is large this causes the page to swirl
around quite noticeably... also the scrollbars that always pop up before
the resize... It would be great if this were tied directly upper in the
chain of events so the plugin would work in-flow.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:6>
CKEditor
---------------------+------------------------------------------------------
Reporter: bronson | Type: Bug
Status: new | Priority: Normal
Version: 3.4.1 | Keywords: HasPatch Discussion
---------------------+------------------------------------------------------
Changes (by garry.yao):
* keywords: HasPatch => HasPatch Discussion
Comment:
I understand you point, but instead there exist some others want to grow
the editor only when editing, so their initial page layout is not broken,
in that sense we may have to revert the editor size on blur instead.
So, we'd provide a config "autoGrowOnlyEditing" to control this, set to
"true" by default maybe.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:7>
CKEditor
---------------------+------------------------------------------------------
Reporter: bronson | Type: Bug
Status: new | Priority: Normal
Version: 3.4.1 | Keywords: HasPatch Discussion
---------------------+------------------------------------------------------
Comment(by alfonsoml):
I'm not sure that the people that wants to preserve a layout are gonna
enable a setting like autogrow.
As you say, if they want it to behave that way we should revert to the
original size on blur, but I haven't see any report about that request, so
I don't think that there are really so much people wanting this.
I would prefer to fix the current problem and when someone request the
alternative behavior then deal with it (but leaving the current behavior
as the default one as it seems more logical for a CMS)
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:8>
CKEditor
---------------------+------------------------------------------------------
Reporter: bronson | Type: Bug
Status: new | Priority: Normal
Version: 3.4.1 | Keywords: HasPatch Discussion
---------------------+------------------------------------------------------
Comment(by ohlavacek):
instanceReady event fires only once - if I create and destroy multiple
editors in a page, only the first one is resized with this event.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:9>
CKEditor
Reporter: bronson | Owner:
Type: Bug | Status: new
Component: General | Version: 3.4.1
----------------------+---------------------------------
Comment (by exim):
If anybody is looking for a temporary workaround that doesn't involve
patching any of the CKEditor code then add this to the javascript code you
use to configure/instantiate the editor:
{{{
CKEDITOR.on('instanceReady', function(ev) { ev.editor.fire('contentDom');
});
}}}
The code above will fire the contentDom event every time a new editor is
instantiated causing it to resize immediately after loading. This said I
still hope that a proper config setting will be added to CKEditor though
so workarounds like this will no longer be needed.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:10>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
Reporter: bronson | Owner:
Type: Bug | Status: closed
Priority: Normal | Milestone: CKEditor 3.6.2
Component: General | Version: 3.4.1
Resolution: fixed | Keywords:
----------------------+----------------------------
Changes (by garry.yao):
* keywords: HasPatch Discussion =>
* status: new => closed
* resolution: => fixed
* milestone: => CKEditor 3.6.2
Comment:
Fixed with [7199]. Tests are to be handled by #8050.
--
Ticket URL: <http://dev.ckeditor.com/ticket/6161#comment:11>
CKEditor <http://ckeditor.com/>
The text editor for the Internet