[CKEditor Dev] #14540: Safari: Opening browser context menu on a link & selecting Open Link option making editor unusable
CKEditor
making editor unusable
-------------------+---------------------
Reporter: satya | Owner:
Type: Bug | Status: new
Priority: Normal | Component: General
Version: 4.5.7 | Keywords: IBM
-------------------+---------------------
== Steps to reproduce ==
1. Open nightly build
[http://nightly.ckeditor.com/16-03-22-07-07/full/samples/]
2. Keep cursor inside link(CK Editor)
3. use CMD + Right click to ope Browser context menu
4. Click on Open Link in Browser context menu
== Issue== Entire CK Editor replaced by the CK Editor page and can't go
back to editor body or click on any options in toolbar
== Browser - Safari 9, OS MAC ==
--
Ticket URL: <http://dev.ckeditor.com/ticket/14540>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
making editor unusable
Reporter: satya | Owner: j.swiderski
Type: Bug | Status: assigned
Priority: Normal | Milestone:
Component: General | Version:
Resolution: | Keywords: IBM
----------------------+-------------------------
Changes (by j.swiderski):
* owner: => j.swiderski
* status: new => assigned
* version: 4.5.7 =>
Old description:
> == Steps to reproduce ==
>
> 1. Open nightly build
> [http://nightly.ckeditor.com/16-03-22-07-07/full/samples/]
> 2. Keep cursor inside link(CK Editor)
> 3. use CMD + Right click to ope Browser context menu
> 4. Click on Open Link in Browser context menu
>
> == Issue== Entire CK Editor replaced by the CK Editor page and can't go
> back to editor body or click on any options in toolbar
>
> == Browser - Safari 9, OS MAC ==
New description:
== Steps to reproduce ==
1. Open nightly build
[http://nightly.ckeditor.com/16-03-22-07-07/full/samples/]
2. Keep cursor inside link(CK Editor)
3. use CMD + Right click to ope Browser context menu
4. Click on Open Link in Browser context menu
== Issue==
Entire CK Editor replaced by the CK Editor page and can't go back to
editor body or click on any options in toolbar
== Browser - Safari 9, OS MAC ==
--
Comment:
I don't quite see area for improvement here.
CKEditor content area is in iframe (it is a different document) and we
deliberately select "Open link" option and not "Open Link in New Window".
How are we supposed to stop this from happening? I personally don't know.
Link is opened from native context menu which sees content area as
document with it should replace with this link.
The only thing that comes to my mind is some sort of custom back button
but that would be a feature request and issue is in fact IMHO such a weird
and rare case that we would probably never have time to implement this
feature.
@m.lewandowski what do you think?
--
Ticket URL: <http://dev.ckeditor.com/ticket/14540#comment:1>
CKEditor
making editor unusable
Reporter: satya | Owner: j.swiderski
Priority: Normal | Milestone:
Component: General | Version:
Resolution: | Keywords: IBM
----------------------+-------------------------
Changes (by j.swiderski):
* status: assigned => pending
--
Ticket URL: <http://dev.ckeditor.com/ticket/14540#comment:2>
CKEditor
making editor unusable
Reporter: satya | Owner: j.swiderski
Type: Bug | Status: pending
Priority: Normal | Milestone:
Component: General | Version:
Resolution: | Keywords: IBM
----------------------+-------------------------
Comment (by m.lewandowski):
Context menu behavior is a native and we can't customize it.
However one way to prevent this kind of confusion is to use window's
beforeunload event, to display a confirmation dialog with an information
like "You're about to replace the CKEditor, are you sure you want to
continue?" or sth among these lines.
But honestly, only Safari has that kind of a feature in convext menu (I
mean to open in the same tab), and it makes it low priority for us.
Definitely needs to be changed to feature request.
@j.swiderski can I ask you to check whether Safari still has an option to
open link in the same tab? They might have removed it since that time. If
it still has, just change the ticket type, status and update title +
description based on expected behavior above.
--
Ticket URL: <http://dev.ckeditor.com/ticket/14540#comment:3>
CKEditor
new page loaded in content area
--------------------------+-------------------------
Reporter: satya | Owner: j.swiderski
Type: New Feature | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version:
Resolution: | Keywords: IBM
Changes (by j.swiderski):
* status: pending => confirmed
* type: Bug => New Feature
Old description:
> == Steps to reproduce ==
>
> 1. Open nightly build
> [http://nightly.ckeditor.com/16-03-22-07-07/full/samples/]
> 2. Keep cursor inside link(CK Editor)
> 3. use CMD + Right click to ope Browser context menu
> 4. Click on Open Link in Browser context menu
>
> == Issue==
> Entire CK Editor replaced by the CK Editor page and can't go back to
> editor body or click on any options in toolbar
>
> == Browser - Safari 9, OS MAC ==
New description:
== Steps to reproduce ==
1. Open nightly build
[http://nightly.ckeditor.com/16-03-22-07-07/full/samples/]
2. Keep cursor inside link(CK Editor)
3. use CMD + Right click to ope Browser context menu
4. Click on Open Link in Browser context menu
== Expected result ==
EDIT: Since we can't change browser behaviour, there should be dialog
displayed (fired on beforeunload event) asking if user wants to leave the
page or not.
== Actual result ==
Entire CKEditor content area is replaced by the CKEditor page and can't go
back to editor body or click on any options in toolbar.
== Other details (browser, OS, CKEditor version, installed plugins) ==
Safari, OS MAC
--
Comment:
This option is still available in latest Safari.
There is an extra problem with opening new link in editor body. When you
are on {{{nightly}}} and you are trying to load {{{ckeditor.com}}} you are
getting {{{Refused to display 'http://ckeditor.com/' in a frame because it
set 'X-Frame-Options' to 'SameOrigin'.}}}. This is happening because most
likely our server is set to its default SAMEORIGIN -
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options
(checkout in Apache section).[[BR]]
This causes a series of problems because when you hover over editor area,
you are getting a ton of errors saying {{{Sandbox access violation:
Blocked a frame at "http://nightly.ckeditor.com" from accessing a frame at
"http://nightly.ckeditor.com". The frame being accessed is sandboxed and
lacks the "allow-same-origin" flag.}}}. When you try to press any button
you are getting {{{this.document.getWindow().$.getSelection is not a
function. (In 'this.document.getWindow().$.getSelection()',
'this.document.getWindow().$.getSelection' is undefined)}}}. All this
makes editor not usable after attempting to open a link.
Unfortunately all the above is beyond editor control. As @m.lewandowski
has pointed out we can only warn user with the dialog but if he decides to
open the page anyway he will lose editor contents.
--
Ticket URL: <http://dev.ckeditor.com/ticket/14540#comment:4>