[CKEditor Dev] #10977: Correct spelling mistake with native spell checker does not trigger change event
CKEditor
event
------------------------+------------------------------------
Reporter: OliverJAsh | Type: Bug
Status: new | Priority: Normal
Component: General | Version: 4.2.2 (GitHub - master)
Keywords: |
------------------------+------------------------------------
If I correct a spelling mistake inside a CKEditor instance using the
native spell checker, the `change` event is not triggered.
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977>
CKEditor <http://ckeditor.com/>
The text editor for the Internet
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: General | Version: 4.2.2 (GitHub - master)
-------------------------+-------------------------------------
Comment (by j.swiderski):
I'm not sure if such spell checked generates any event we can hook into.
In such case this is a won't fix issue.
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:1>
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: new
Priority: Normal | Milestone:
Component: General | Version: 4.2.2 (GitHub - master)
-------------------------+-------------------------------------
Comment (by OliverJAsh):
Could you look into it?
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:2>
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 4.2
-------------------------+-----------------------
Changes (by Reinmar):
* status: new => confirmed
* version: 4.2.2 (GitHub - master) => 4.2
Comment:
In my opinion the issue is wider. We do not support native spell checkers
for a reason - we cannot hook into them. That's why our undo manager
(which is responsible for firing 'change' event) does not know that
something's changed.
However, since the native 'input' event was introduced, most likely it
will be possible to listen on changes done by native spell checker as well
as on changes coming from other sources (e.g. drag&drop for which we'll
blind too iirc). I was postulating that undo manager should listen on
'input' and there's a chance that we'll do such change. It not a quick fix
though.
Anyway, this issue can be fixed, but it just has to wait for changes undo
manager.
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:3>
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 4.2
Resolution: | Keywords:
-------------------------+-----------------------
Comment (by j.swiderski):
#16832 was marked as duplicate.
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:4>
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: confirmed
Priority: Normal | Milestone:
Component: General | Version: 4.2
Resolution: | Keywords:
-------------------------+-----------------------
Comment (by jtermaat):
This issue still seems to be present in CKEditor. Is it already possible
to fix this?
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:5>
CKEditor
event
Reporter: OliverJAsh | Owner:
Type: Bug | Status: closed
Priority: Normal | Milestone:
Component: General | Version: 4.2
-------------------------+--------------------
Changes (by j.swiderski):
* status: confirmed => closed
* resolution: => fixed
Comment:
From what I have checked, native spell checkers in Firefox, Chrome and
Safari now fire input event. What is more correcting a word, in CKEditor
with native spell checker, updates the undo manager and it is possible to
revert that change with {{{Undo}}} button or {{{Ctrl+Z}}}
To test this it is enough to enable editor with naive spell checker
(logger in example below is just to show that input event is fired), type
few misspell words e.g. {{{I'm back on mondayy}}}, correct them and
undo/redo them.
{{{
var editor = CKEDITOR.replace( 'editor1', {
disableNativeSpellChecker : false
});
editor.on( 'pluginsLoaded', function( evt )
{
editor.on( 'contentDom', function( e )
{
var editable = editor.editable();
var doc = editor.document;
editable.attachListener( doc, 'input', function( event )
{
console.log('here');
}, 1 );
});
});
}}}
Seems the issue is fixed.
--
Ticket URL: <http://dev.ckeditor.com/ticket/10977#comment:6>