nits

104 views
Skip to first unread message

Bob Jenkins

unread,
Oct 20, 2011, 12:46:49 AM10/20/11
to cityhash-discuss
Although the tar.gz for CityHash 1.0.3 has an #include "config.h", no
config.h comes in that tar.gz .

CRCs are a specific family of functions. For example that family of
functions has the property that a message can be split into pieces,
and the CRC of the whole can be computed from the CRCs and lengths of
the pieces. CityHashCrc256() doesn't implement a CRC and doesn't have
that property. Call it something else please. Checksum is fine, CRC
is not.

The code has constants like 240 repeated many times. Please define a
macro or a static const int or such if a constant appears more than
once.

Geoff Pike

unread,
Oct 20, 2011, 5:04:24 PM10/20/11
to cityhash-discuss
Thanks Bob. We'll try to address at least some of these issues in
future releases.

Geoff

Bob Jenkins

unread,
Oct 22, 2011, 7:00:30 PM10/22/11
to cityhash-discuss
A crc32 instruction! Wow. That explains the reference to crc. No
computer I have access to has that. 6 bytes per cycle? Wow. Time to
get myself up to speed again ...

1971 powerChina

unread,
May 6, 2015, 11:57:14 PM5/6/15
to cityhash...@googlegroups.com, bobjen...@gmail.com
Reply all
Reply to author
Forward
0 new messages