[PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml

[Jianpi...@de.bosch.com]

From: "Shen Jianping (ME-SE/EAD2)" <she...@LR-C-0008DVM.rt.de.bosch.com>

dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml
Signed-off-by: Shen Jianping (ME-SE/EAD2) <she...@LR-C-0008DVM.rt.de.bosch.com>
---
.../bindings/iio/imu/bosch,smi240.yaml | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml

diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
new file mode 100644
index 00000000000..5e89d85d867
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/imu/bosch,smi240.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bosch SMI240 IMU
+
+maintainers:
+ - Jianping Shen <Jianpi...@de.bosch.com>
+
+description: |
+ The SMI240 is a combined three axis angular rate and three axis acceleration sensor module
+ with a measurement range of +/-300°/s and up to 16g. SMI240 does not support interrupt.
+ https://www.bosch-semiconductors.com/mems-sensors/highly-automated-driving/smi240/
+
+properties:
+ compatible:
+ const: bosch,smi240
+
+ reg:
+ maxItems: 1
+
+ vdd-supply:
+ description: provide VDD power to the sensor.
+
+ vddio-supply:
+ description: provide VDD IO power to the sensor.
+
+required:
+ - compatible
+ - reg
+
+allOf:
+ - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ spi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ spi@0 {
+ compatible = "bosch,smi240";
+ reg = <0>;
+ spi-max-frequency = <10000000>;
+ };
+ };
--
2.34.1

[Shen Jianping (ME-SE/EAD2)]

Anyway, please send bindings with driver in the same patchset.

-> It's fine for us. Nevertheless according to the Devicetree (DT) binding submitting rules 1.1

" The Documentation/ and include/dt-bindings/ portion of the patch should be a separate patch." See -> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Shall we still put the binding and driver in the same patch ?

Mit freundlichen Grüßen / Best regards

Jianping Shen

Mobility Electronics - Sensors, Engineering Advanced Development - MEMS Solutions Software (ME-SE/EAD2)
Robert Bosch GmbH | Postfach 13 42 | 72703 Reutlingen | GERMANY | www.bosch.com
Tel. +49 7121 35-37749 | Telefax +49 711 811-509378 | Jianpi...@de.bosch.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000;
Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer;
Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner,
Stefan Grosch, Dr. Markus Heyn, Dr. Frank Meyer, Dr. Tanja Rückert

-----Original Message-----
From: Krzysztof Kozlowski <kr...@kernel.org>
Sent: Wednesday, July 24, 2024 3:17 PM
To: Shen Jianping (ME-SE/EAD2) <Jianpi...@de.bosch.com>; ji...@kernel.org; la...@metafoo.de; ro...@kernel.org; krz...@kernel.org; cono...@kernel.org; dima....@gmail.com; marcelo....@gmail.com; linu...@vger.kernel.org; devic...@vger.kernel.org; linux-...@vger.kernel.org; Lorenz Christian (ME-SE/EAD2) <Christia...@de.bosch.com>; Frauendorf Ulrike (ME/PJ-SW3) <Ulrike.F...@de.bosch.com>; Dolde Kai (ME-SE/PAE-A3) <Kai....@de.bosch.com>
Subject: Re: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml

On 24/07/2024 14:51, Jianpi...@de.bosch.com wrote:
> From: "Shen Jianping (ME-SE/EAD2)"
> <she...@LR-C-0008DVM.rt.de.bosch.com>
>
> dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml

Something got corrupted here.

Anyway, please send bindings with driver in the same patchset.

Limited review follows:

> Signed-off-by: Shen Jianping (ME-SE/EAD2)
> <she...@LR-C-0008DVM.rt.de.bosch.com>
> ---

Missing changelog. That's v2, not v1? Provide changelog under --- and version your patches correctly. b4 does it for you...

> .../bindings/iio/imu/bosch,smi240.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
>
> diff --git
> a/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> new file mode 100644
> index 00000000000..5e89d85d867
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,smi240.yaml
> @@ -0,0 +1,50 @@

> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> +---
> +$id:
> +https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fschemas%2Fiio%2Fimu%2Fbosch%2Csmi240.yaml%23&data=05%7C0
> +2%7CJianping.Shen%40de.bosch.com%7Ce4bd3cadbf5f4b17bf7308dcabe2e9b6%7
> +C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638574238283264004%7CUnkn
> +own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWw
> +iLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=gbcSKWPDSDT0qTWo5L%2FUYxlQDunqNl2l
> +L7JAxwHhNJY%3D&reserved=0
> +$schema:
> +https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C02%7CJianping.Shen
> +%40de.bosch.com%7Ce4bd3cadbf5f4b17bf7308dcabe2e9b6%7C0ae51e1907c84e4b
> +bb6d648ee58410f4%7C0%7C0%7C638574238283281959%7CUnknown%7CTWFpbGZsb3d
> +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> +C0%7C%7C%7C&sdata=kW25MDdZz9c3ePA%2BUrGXSWsBWlDxb6UAKjOeLSnFEXU%3D&re
> +served=0

> +
> +title: Bosch SMI240 IMU
> +
> +maintainers:
> + - Jianping Shen <Jianpi...@de.bosch.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + The SMI240 is a combined three axis angular rate and three axis

> + acceleration sensor module with a measurement range of +/-300°/s and up to 16g. SMI240 does not support interrupt.
> +
> + https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> + w.bosch-semiconductors.com%2Fmems-sensors%2Fhighly-automated-driving
> + %2Fsmi240%2F&data=05%7C02%7CJianping.Shen%40de.bosch.com%7Ce4bd3cadb
> + f5f4b17bf7308dcabe2e9b6%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7
> + C638574238283298041%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
> + IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=d2%2Bk
> + j8GzUms9o0Nbdu9QpTzZwujQnjJMp0GFp%2B5MrB0%3D&reserved=0

This does not look like wrapped according to Linux Coding Style. See Coding Style, so 80.

That's not a SPI controller. Your description suggests "imu".

Best regards,
Krzysztof

[Shen Jianping (ME-SE/EAD2)]

Hello Jonathan,

Thank you for the explanation ! We will construct the patch-set as you suggested.

Since the rework of the driver still takes some time, we will send the new version once we finish it.

Mit freundlichen Grüßen / Best regards

Jianping Shen

Mobility Electronics - Sensors, Engineering Advanced Development - MEMS Solutions Software (ME-SE/EAD2)
Robert Bosch GmbH | Postfach 13 42 | 72703 Reutlingen | GERMANY | www.bosch.com
Tel. +49 7121 35-37749 | Telefax +49 711 811-509378 | Jianpi...@de.bosch.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000;
Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer;
Geschäftsführung: Dr. Stefan Hartung, Dr. Christian Fischer, Dr. Markus Forschner,
Stefan Grosch, Dr. Markus Heyn, Dr. Frank Meyer, Dr. Tanja Rückert

-----Original Message-----
From: Jonathan Cameron <ji...@kernel.org>
Sent: Saturday, July 27, 2024 4:00 PM
To: Conor Dooley <co...@kernel.org>
Cc: Shen Jianping (ME-SE/EAD2) <Jianpi...@de.bosch.com>; Krzysztof Kozlowski <kr...@kernel.org>; la...@metafoo.de; ro...@kernel.org; krz...@kernel.org; cono...@kernel.org; dima....@gmail.com; marcelo....@gmail.com; linu...@vger.kernel.org; devic...@vger.kernel.org; linux-...@vger.kernel.org; Lorenz Christian (ME-SE/EAD2) <Christia...@de.bosch.com>; Frauendorf Ulrike (ME/PJ-SW3) <Ulrike.F...@de.bosch.com>; Dolde Kai (ME-SE/PAE-A3) <Kai....@de.bosch.com>
Subject: Re: [PATCH] dt-bindings: iio: imu: SMI240: add bosch,smi240.yaml

On Wed, 24 Jul 2024 16:25:39 +0100
Conor Dooley <co...@kernel.org> wrote:

> On Wed, Jul 24, 2024 at 02:19:25PM +0000, Shen Jianping (ME-SE/EAD2) wrote:
> > Anyway, please send bindings with driver in the same patchset.
> >
> > -> It's fine for us. Nevertheless according to the Devicetree (DT)

> > -> binding submitting rules 1.1

> >
> > " The Documentation/ and include/dt-bindings/ portion of the patch
> > should be a separate patch." See ->

> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > w.kernel.org%2Fdoc%2Fhtml%2Flatest%2Fdevicetree%2Fbindings%2Fsubmitt
> > ing-patches.html%23i-for-patch-submitters&data=05%7C02%7CJianping.Sh
> > en%40de.bosch.com%7C3d03781ae4564e7e3f7708dcae447463%7C0ae51e1907c84
> > e4bbb6d648ee58410f4%7C0%7C0%7C638576856248420833%7CUnknown%7CTWFpbGZ
> > sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0
> > %3D%7C0%7C%7C%7C&sdata=OEaFoGpb%2F7CVAN2gEpNwG9I1zGBlUNYdLUy%2F7w5Dh
> > b0%3D&reserved=0

> >
> > Shall we still put the binding and driver in the same patch ?
>

> No, different patches please. Also, please fix your mail client so
> that it quotes emails properly.
To add a little more detail.
We are looking for a cover letter and a pair of patches.
1st adds the dt-binding docs.
2nd provides the driver.

The cover letter provides a brief summary of the whole series and provides a convenient name for tracking it as a whole.

Take a look at how other recent driver addition patch series have been broken up.

Jonathan