Re: [PATCH v2 3/7] pwm: max7360: Add MAX7360 PWM support

[Christophe JAILLET]

Le 23/12/2024 à 17:42, mathieu.du...@bootlin.com a écrit :
> From: Kamel Bouhara <kamel....@bootlin.com>
>
> Add driver for Maxim Integrated MAX7360 PWM controller, supporting up to
> 8 independent PWM outputs.
>
> Signed-off-by: Kamel Bouhara <kamel....@bootlin.com>
> Signed-off-by: Mathieu Dubois-Briand <mathieu.du...@bootlin.com>

...

> +static int max7360_pwm_probe(struct platform_device *pdev)
> +{
> + struct max7360_pwm *max7360_pwm;
> + struct pwm_chip *chip;
> + int ret;
> +
> + if (!pdev->dev.parent)
> + return dev_err_probe(&pdev->dev, -ENODEV, "no parent device\n");
> +
> + chip = devm_pwmchip_alloc(pdev->dev.parent, MAX7360_NUM_PWMS,
> + sizeof(*max7360_pwm));
> + if (IS_ERR(chip))
> + return PTR_ERR(chip);
> + chip->ops = &max7360_pwm_ops;
> +
> + max7360_pwm = to_max7360_pwm(chip);
> + max7360_pwm->parent = pdev->dev.parent;
> +
> + max7360_pwm->regmap = dev_get_regmap(pdev->dev.parent, NULL);
> + if (!max7360_pwm->regmap)
> + return dev_err_probe(&pdev->dev, -ENODEV,
> + "could not get parent regmap\n");
> +
> + ret = devm_pwmchip_add(&pdev->dev, chip);
> + if (ret != 0)
> + dev_err_probe(&pdev->dev, ret, "failed to add PWM chip");

Missing return, or done on purpose?

> +
> + return 0;
> +}