Redesign scope API, separate declarative and object scopes. (issue 11602013)

[peter...@gmail.com]

Reviewers: apavlov,

Message:
TBR=apa...@chromium.org

Description:
Redesign scope API, separate declarative and object scopes.


Please review this at https://codereview.chromium.org/11602013/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/StackFrame.java
M
plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/ValueBase.java
M
plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/Variable.java
M
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
M plugins/org.chromium.sdk/src/org/chromium/sdk/JsScope.java
M
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java

[apa...@chromium.org]

lgtm with comments


https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
File
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
(right):

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode598
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:598:
@Override public ObjectBased asObjectBased() {
blank line above

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode601
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:601:
@Override public <R> R accept(Visitor<R> visitor) {
ditto

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode691
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:691:
@Override public ObjectBased asObjectBased() {
ditto

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode694
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:694:
@Override public <R> R accept(Visitor<R> visitor) {
ditto

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java
(right):

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode205
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:205:
@Override public ObjectBased asObjectBased() {
ditto

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode208
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:208:
@Override public <R> R accept(Visitor<R> visitor) {
ditto

https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode245
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:245:
@Override boolean isCacheObsolete(int newCacheState) {
ditto

https://codereview.chromium.org/11602013/