Groups
Groups
Sign in
Groups
Groups
chromedevtools-codereview
Conversations
About
Send feedback
Help
fix npe issue #81 (issue 11821037)
1 view
Skip to first unread message
peter...@gmail.com
unread,
Jan 9, 2013, 5:24:04 PM
1/9/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reviewers: apavlov,
Description:
fix npe issue #81
Please review this at
https://codereview.chromium.org/11821037/
SVN Base:
https://chromedevtools.googlecode.com/svn/trunk
Affected files:
M
plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
Index:
plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
diff --git
a/plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
b/plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
index
2c13e3bc3194f00c0d50d1232ca2b6856e96b351..72dae21ff62bf9d25d5df02c91eca900575e6261
100644
---
a/plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
+++
b/plugins/
org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
@@ -125,7 +125,12 @@ public class WipBackendImpl extends WipBackendBase {
private String readHttpResponseContent(InetSocketAddress socketAddress,
String resource,
LoggerFactory loggerFactory) throws IOException {
- ConnectionLogger browserConnectionLogger =
loggerFactory.newBrowserConnectionLogger();
+ ConnectionLogger browserConnectionLogger;
+ if (loggerFactory == null) {
+ browserConnectionLogger = null;
+ } else {
+ browserConnectionLogger = loggerFactory.newBrowserConnectionLogger();
+ }
final SocketWrapper socketWrapper = new SocketWrapper(
socketAddress, DEFAULT_CONNECTION_TIMEOUT_MS,
browserConnectionLogger,
HandshakeUtil.ASCII_CHARSET);
peter...@gmail.com
unread,
Jan 9, 2013, 5:25:01 PM
1/9/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to apa...@chromium.org, chromedevtoo...@googlegroups.com
TBR=
apa...@chromium.org
https://codereview.chromium.org/11821037/
Alexander Pavlov
unread,
Jan 10, 2013, 4:22:38 AM
1/10/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Peter Rybin, chromedevtoo...@googlegroups.com
LGTM
On Thu, Jan 10, 2013 at 2:25 AM,
<
peter...@gmail.com
>
wrote:
TBR=
apa...@chromium.org
https://codereview.chromium.
org/11821037/
--
-alexander
apa...@chromium.org
unread,
Jan 10, 2013, 4:24:26 AM
1/10/13
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to peter...@gmail.com, chromedevtoo...@googlegroups.com
lgtm
https://codereview.chromium.org/11821037/
Reply all
Reply to author
Forward
0 new messages