fix npe issue #81 (issue 11821037)

1 view
Skip to first unread message

peter...@gmail.com

unread,
Jan 9, 2013, 5:24:04 PM1/9/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reviewers: apavlov,

Description:
fix npe issue #81


Please review this at https://codereview.chromium.org/11821037/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java


Index:
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
diff --git
a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
index
2c13e3bc3194f00c0d50d1232ca2b6856e96b351..72dae21ff62bf9d25d5df02c91eca900575e6261
100644
---
a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
+++
b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
@@ -125,7 +125,12 @@ public class WipBackendImpl extends WipBackendBase {

private String readHttpResponseContent(InetSocketAddress socketAddress,
String resource,
LoggerFactory loggerFactory) throws IOException {
- ConnectionLogger browserConnectionLogger =
loggerFactory.newBrowserConnectionLogger();
+ ConnectionLogger browserConnectionLogger;
+ if (loggerFactory == null) {
+ browserConnectionLogger = null;
+ } else {
+ browserConnectionLogger = loggerFactory.newBrowserConnectionLogger();
+ }
final SocketWrapper socketWrapper = new SocketWrapper(
socketAddress, DEFAULT_CONNECTION_TIMEOUT_MS,
browserConnectionLogger,
HandshakeUtil.ASCII_CHARSET);


peter...@gmail.com

unread,
Jan 9, 2013, 5:25:01 PM1/9/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com

Alexander Pavlov

unread,
Jan 10, 2013, 4:22:38 AM1/10/13
to Peter Rybin, chromedevtoo...@googlegroups.com
LGTM





--
-alexander

apa...@chromium.org

unread,
Jan 10, 2013, 4:24:26 AM1/10/13
to peter...@gmail.com, chromedevtoo...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages