Fix NPE part 2 (issue 11833019)

2 views
Skip to first unread message

peter...@gmail.com

unread,
Jan 9, 2013, 5:30:48 PM1/9/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reviewers: apavlov,

Description:
Fix NPE part 2
BUG=81


Please review this at https://codereview.chromium.org/11833019/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java


Index:
plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
diff --git
a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
index
c9cc0f4d9d50e4d8dca761734a4dc8587d47916c..5d4cc01069d345e9a772e508f00e1ee7d616027b
100644
---
a/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
+++
b/plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipBackendImpl.java
@@ -125,7 +125,12 @@ public class WipBackendImpl extends WipBackendBase {

private String readHttpResponseContent(InetSocketAddress socketAddress,
String resource,
LoggerFactory loggerFactory) throws IOException {
- ConnectionLogger browserConnectionLogger =
loggerFactory.newBrowserConnectionLogger();
+ ConnectionLogger browserConnectionLogger;
+ if (loggerFactory == null) {
+ browserConnectionLogger = null;
+ } else {
+ browserConnectionLogger = loggerFactory.newBrowserConnectionLogger();
+ }
final SocketWrapper socketWrapper = new SocketWrapper(
socketAddress, DEFAULT_CONNECTION_TIMEOUT_MS,
browserConnectionLogger,
HandshakeUtil.ASCII_CHARSET);


Alexander Pavlov

unread,
Jan 10, 2013, 4:23:11 AM1/10/13
to Peter Rybin, chromedevtoo...@googlegroups.com
LGTM
--
-alexander

apa...@chromium.org

unread,
Jan 10, 2013, 4:23:48 AM1/10/13
to peter...@gmail.com, chromedevtoo...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages