Add 'type' field to tab enumeration JSON protocol (issue 12036084)

1 view
Skip to first unread message

peter...@gmail.com

unread,
Jan 24, 2013, 8:59:01 AM1/24/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reviewers: apavlov,

Message:
TBR=apa...@chromium.org

Description:
Add 'type' field to tab enumeration JSON protocol


Please review this at https://codereview.chromium.org/12036084/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java


Index:
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java
diff --git
a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java
b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java
index
723dff327fdbb6d263e5eb8aed3896cf5fef5052..e0aed1d50666d24e8f1fca55738a1e321245ca78
100644
---
a/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java
+++
b/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/protocol/input/WipTabList.java
@@ -22,6 +22,9 @@ public interface WipTabList {

String thumbnailUrl();

+ // TODO: consider adding enum here
+ String type();
+
@JsonOptionalField
String devtoolsFrontendUrl();



Reply all
Reply to author
Forward
0 new messages