Disaply compile error position in editor (issue 12040008)

[peter...@gmail.com]

Reviewers: apavlov,

Description:
Disaply compile error position in editor


Please review this at https://codereview.chromium.org/12040008/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/LiveEditWizardAction.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/PushChangesWizard.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/WizardLogicBuilder.java
M
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
M
plugins/org.chromium.sdk.wipbackend.protocol_1_0/src/org/chromium/sdk/internal/wip/WipScriptImpl.java

[apa...@chromium.org]

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java#newcode341
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java:341:
return NLS.bind("{0} ({1}:{2})", new Object[] { //$NON-NLS-1$
Is it by chance a list... argument?

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java#newcode9
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java:9:
public static String LiveEditResultDialog_COMPLILE_ERROR;
Typo: COMPILE_ERROR

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties#newcode8
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties:8:
LiveEditResultDialog_MOVE_CARET=Move editor caret
"Select"/"Navigate"/"Navigate to location"?

The current variation is very suboptimal

https://codereview.chromium.org/12040008/

[peter...@gmail.com]

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java#newcode341
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/LiveEditResultDialog.java:341:
return NLS.bind("{0} ({1}:{2})", new Object[] { //$NON-NLS-1$

On 2013/01/22 06:38:10, apavlov wrote:
> Is it by chance a list... argument?

No

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java#newcode9
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/Messages.java:9:
public static String LiveEditResultDialog_COMPLILE_ERROR;

On 2013/01/22 06:38:10, apavlov wrote:
> Typo: COMPILE_ERROR

Done.

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
(right):

https://codereview.chromium.org/12040008/diff/6001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties#newcode8
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties:8:
LiveEditResultDialog_MOVE_CARET=Move editor caret

On 2013/01/22 06:38:10, apavlov wrote:
> "Select"/"Navigate"/"Navigate to location"?

> The current variation is very suboptimal

Done.

https://codereview.chromium.org/12040008/

[apa...@chromium.org]

LGTM with a nit


https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
File
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties
(right):

https://codereview.chromium.org/12040008/diff/9001/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties#newcode8
plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/liveedit/messages.properties:8:
LiveEditResultDialog_MOVE_CARET=Select in editor
I'd suggest that you fix the message name, too.

https://codereview.chromium.org/12040008/