Re: Redesign scope API, separate declarative and object scopes. (issue 11602013)
1 view
Skip to first unread message
peter...@gmail.com
Jan 9, 2013, 10:30:31 AM1/9/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
File
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java
(right):
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode598
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:598:
@Override public ObjectBased asObjectBased() {
On 2012/12/27 08:02:16, apavlov wrote:
> blank line above
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode601
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:601:
@Override public <R> R accept(Visitor<R> visitor) {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode691
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:691:
@Override public ObjectBased asObjectBased() {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java#newcode694
plugins/org.chromium.sdk.wipbackend.dev/src/org/chromium/sdk/internal/wip/WipContextBuilder.java:694:
@Override public <R> R accept(Visitor<R> visitor) {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java
File
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java
(right):
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode205
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:205:
@Override public ObjectBased asObjectBased() {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode208
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:208:
@Override public <R> R accept(Visitor<R> visitor) {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/diff/2001/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java#newcode245
plugins/org.chromium.sdk/src/org/chromium/sdk/internal/v8native/value/JsScopeImpl.java:245:
@Override boolean isCacheObsolete(int newCacheState) {
On 2012/12/27 08:02:16, apavlov wrote:
> ditto
Done.
https://codereview.chromium.org/11602013/
peter...@gmail.com
Jan 9, 2013, 11:30:43 AM1/9/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages