Drop TODO for getVmVersion method (issue 12324002)

1 view
Skip to first unread message

peter...@gmail.com

unread,
Feb 19, 2013, 10:10:05 PM2/19/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Reviewers: apavlov,

Message:
TBR=apa...@chromium.org

Description:
Drop TODO for getVmVersion method


Please review this at https://codereview.chromium.org/12324002/

SVN Base: https://chromedevtools.googlecode.com/svn/trunk

Affected files:
M plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java


Index: plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
diff --git
a/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
b/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
index
c922622fd4f02654db0962a441dba0778772c2a4..db00516d3a482a1e02116a24b954f8a466819edc
100644
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/StandaloneVm.java
@@ -33,10 +33,11 @@ public interface StandaloneVm extends JavascriptVm {
String getEmbedderName();

/**
+ * This version should correspond to {@link JavascriptVm#getVersion()}.
However it gets available
+ * earlier, at the transport handshake stage.
* @return version of V8 implementation, format is unspecified; must not
be null if
* {@link StandaloneVm} has been attached
*/
- // TODO: align this with {@link JavascriptVm#getVersion()} method.
String getVmVersion();

/**


peter...@gmail.com

unread,
Feb 19, 2013, 10:10:44 PM2/19/13
to apa...@chromium.org, chromedevtoo...@googlegroups.com
Committed manually as r1139 (presubmit successful).

https://codereview.chromium.org/12324002/
Reply all
Reply to author
Forward
0 new messages