Strategy to concat Vec objects

[edm...@edmondcote.com]

Believe that this question was asked before, but to no avail: https://stackoverflow.com/questions/51437942/chisel-concatenation-error

Can anyone think of a better strategy to concatenate two Vec objects?  Other than using generators that is, e.g.:

val storeTableWalkerRequest: Vec[Bool] = Wire(Vec(NumStorePorts, Bool()))

val loadTableWalkerRequest: Vec[Bool] = Wire(Vec(NumLoadPorts, Bool()))

// Concatenate all request vectors

val tableWalkerRequests: Vec[Bool] = Wire(Vec(NumStorePorts + NumLoadPorts, Bool()))

for (i <- 0 until NumStorePorts) {
  tableWalkerRequests(i) := storeTableWalkerRequest(i)
}

for (i <- NumStorePorts until NumStorePorts + NumLoadPorts) {
  tableWalkerRequests(i) := loadTableWalkerRequest(i - NumStorePorts)
}

[Andrew Waterman]

Perhaps something like: VecInit((storeTableWalkerRequest ++ loadTableWalkerRequest):_*)

--
You received this message because you are subscribed to the Google Groups "chisel-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users+unsubscribe@googlegroups.com.
To post to this group, send email to chisel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/34f45830-9f55-4cbf-8ddc-908c632c477f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Edmond Cote]

Thanks, Andrew!  I appreciate the tip, but "no dice" :(

val tableWalkerRequests: Vec[Bool] = Wire(VecInit((storerTableWalkerRequest ++ loaderTableWalkerRequest):_*))

// no `: _*' annotation allowed here (such annotations are only allowed in arguments to *-parameters)

val tableWalkerRequests: Vec[Bool] = Wire(VecInit(storerTableWalkerRequest ++ loaderTableWalkerRequest))

// wire type 'Vec(chisel3.core.Bool@2311, chisel3.core.Bool@2313, [..])' must be a Chisel type, not hardware

On Thu, Sep 6, 2018 at 11:47 AM Andrew Waterman <wate...@eecs.berkeley.edu> wrote:

Perhaps something like: VecInit((storeTableWalkerRequest ++ loadTableWalkerRequest):_*)

On Thu, Sep 6, 2018 at 11:44 AM, <edm...@edmondcote.com> wrote:

Believe that this question was asked before, but to no avail: https://stackoverflow.com/questions/51437942/chisel-concatenation-error

Can anyone think of a better strategy to concatenate two Vec objects?  Other than using generators that is, e.g.:

val storeTableWalkerRequest: Vec[Bool] = Wire(Vec(NumStorePorts, Bool()))

val loadTableWalkerRequest: Vec[Bool] = Wire(Vec(NumLoadPorts, Bool()))

// Concatenate all request vectors

val tableWalkerRequests: Vec[Bool] = Wire(Vec(NumStorePorts + NumLoadPorts, Bool()))

for (i <- 0 until NumStorePorts) {
  tableWalkerRequests(i) := storeTableWalkerRequest(i)
}

for (i <- NumStorePorts until NumStorePorts + NumLoadPorts) {
  tableWalkerRequests(i) := loadTableWalkerRequest(i - NumStorePorts)
}

--
You received this message because you are subscribed to the Google Groups "chisel-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users...@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/34f45830-9f55-4cbf-8ddc-908c632c477f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "chisel-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users...@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/CA%2B%2B6G0DPVLn6ec2t3-foLtB%2BgHgFmHnuhaRn%2B7Q40W-ba3unPg%40mail.gmail.com.

[Steve Burns]

How about this slight modification:

VecInit(IndexedSeq((storeTableWalkerRequest ++ loadTableWalkerRequest):_*) )

To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/CALzVNFB8vHZ0Z65gFyXR3oQM-%2BbfvRGjPZjVBxb0TaBjGkchsQ%40mail.gmail.com.

[Steve Burns]

Seems to work:

package vec_append

import chisel3._

import chisel3.util._

import chisel3.iotesters._

import org.scalatest.{Matchers, FlatSpec}

class Tl extends Module {

  val io = IO(new Bundle {

    val a = Input(Vec(2,UInt(4.W)))

    val b = Input(Vec(3,UInt(4.W)))

    val z = Output(Vec(5,UInt(4.W)))

  })

  io.z := VecInit( IndexedSeq( (io.a ++ io.b):_*))

}

class Tester(c: Tl) extends PeekPokeTester(c) {

    poke( c.io.a(0), 0)

    poke( c.io.a(1), 1)

    poke( c.io.b(0), 10)

    poke( c.io.b(1), 11)

    poke( c.io.b(2), 12)

    step(1)

    expect( c.io.z(0), 0)

    expect( c.io.z(1), 1)

    expect( c.io.z(2), 10)

    expect( c.io.z(3), 11)

    expect( c.io.z(4), 12)

}

class Test extends FlatSpec with Matchers {

  behavior of "Test"

  it should "work" in {

    chisel3.iotesters.Driver( () => new Tl, "firrtl") { c =>

      new Tester(c)

    } should be (true)

  }

}

[Edmond Cote]

Hi Steve,

Simply wanted to confirm that I have it working as well.

In the second case where I highlighted a "must be a Chisel type, not hardware" error, I made the mistake of making the assignment of a Bool() to a DecoupledIO() interface.  This works great!

val reqs = io.load.map(_.read) ++ io.store.map(_.write)

arbiter.io.in.zipWithIndex.foreach {
  case (in, index) =>
    in.valid := reqs(index)
    in.bits := 0.U // don't care
}

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users+unsubscribe@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/34f45830-9f55-4cbf-8ddc-908c632c477f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "chisel-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users+unsubscribe@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/CA%2B%2B6G0DPVLn6ec2t3-foLtB%2BgHgFmHnuhaRn%2B7Q40W-ba3unPg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "chisel-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users+unsubscribe@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/CALzVNFB8vHZ0Z65gFyXR3oQM-%2BbfvRGjPZjVBxb0TaBjGkchsQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

You received this message because you are subscribed to the Google Groups "chisel-users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chisel-users+unsubscribe@googlegroups.com.

To post to this group, send email to chisel...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/chisel-users/CANFzVijneThrfeQN0MQZQZj8FdKSydFu-XBca168Lp3scc13Kw%40mail.gmail.com.