Missing standard classes if registration is required

20 views
Skip to first unread message

Georg

unread,
Dec 19, 2017, 9:48:26 AM12/19/17
to chill-user
Hi chill folks,

my question relates to chill issue #227 but goes a bit further. There, rcoh (in other words) reports that "::" is not registered by the AllScalaRegistrar, which makes things more complicated if you run your code with setRegistrationRequired(true). The same is true for quite a number of standard Scala classes, among others:

scala.None
scala.collection.immutable.::
scala.collection.immutable.Nil
scala.collection.immutable.ListSet.EmptyListSet
scala.collection.immutable.Range
scala.collection.mutable.WrappedArray.ofRef
int[]

Would you (probably) accept a pull request that would add ten or more standard classes to the registrations in AllScalaRegistrar? If yes, I would create one. (Otherwise, I will register those classes "by hand" in our own application.)

And if yes, I propose I add the classes to the end, so registration numbers of the other scala classes do not change, and compatibility is maintained as far as possible (like rcoh also proposed). Reason: In our application, I need long time stable identifiers for all classes involved because I want to use kryo/chill for persistence with setRegistrationRequired(true). And with my PR I don't want to break other clients already using chill in that way...

Or would you explicitly prefer having the classes added to their natural places (even if this might break compatibility for certain use cases)?

Regards
Georg

P. Oscar Boykin

unread,
Jan 2, 2018, 1:14:15 PM1/2/18
to chill-user
Sorry for the delay.

We would accept a patch!
Reply all
Reply to author
Forward
0 new messages