boss_migrate migrating to boss_db ?

[David Welton]

Hi,

How would you guys feel about moving boss_migrate to boss_db? I think
we could replace boss_files:root_priv_dir with code:priv_dir(App) and
thus separate it completely from Chicago Boss itself.

--
David N. Welton

http://www.welton.it/davidw/

http://www.dedasys.com/

[Fredrik de Vibe]

Hi David,

David Welton <davidn...@gmail.com>
writes:

> Hi,
>
> How would you guys feel about moving boss_migrate to boss_db? I think
> we could replace boss_files:root_priv_dir with code:priv_dir(App) and
> thus separate it completely from Chicago Boss itself.

I think it sounds like a very good idea to extract boss_migrate from
boss core.

How about extracting it into its own project, with a dependency from
boss_db (or boss core, if that should make more sense)? Added benefits
would be, as I see it, that the architecture would better support
separation of concerns and minimizing interdependencies, as well as
enabling users to easily exchange boss_migrate for something else, or
use a different version or a fork if one should want that. On the
downside, of course there is dependency management and possibly more
work in the separation process. I don't know how much work this would
require, so I can't really say anything very sensible about cost /
benefit here.



- Fredrik

[David Welton]

Hi,

>> How would you guys feel about moving boss_migrate to boss_db? I think
>> we could replace boss_files:root_priv_dir with code:priv_dir(App) and
>> thus separate it completely from Chicago Boss itself.
>
> I think it sounds like a very good idea to extract boss_migrate from
> boss core.
>
> How about extracting it into its own project,

It's 40 something lines of code in 1 file. I'd rather put it in boss_db.

[Fredrik de Vibe]

David Welton <davidn...@gmail.com>
writes:

> Hi,
>
>>> How would you guys feel about moving boss_migrate to boss_db? I think
>>> we could replace boss_files:root_priv_dir with code:priv_dir(App) and
>>> thus separate it completely from Chicago Boss itself.
>>
>> I think it sounds like a very good idea to extract boss_migrate from
>> boss core.
>>
>> How about extracting it into its own project,
>
> It's 40 something lines of code in 1 file. I'd rather put it in boss_db.

I can see that would make for an expensive standalone project. :-)

OTOH, if it could help in getting others to expand on it, it *might*
give additional benefits, I'm not one to answer this, though. And please
don't misinterpret me, I don't protest putting it into boss_db, this is
just a (fairly general) suggestion. :-)


- Fredrik

[David Welton]

Hi,

>> It's 40 something lines of code in 1 file. I'd rather put it in boss_db.
>
> I can see that would make for an expensive standalone project. :-)
>
> OTOH, if it could help in getting others to expand on it, it *might*
> give additional benefits, I'm not one to answer this, though. And please
> don't misinterpret me, I don't protest putting it into boss_db, this is
> just a (fairly general) suggestion. :-)

It also calls directly into boss_db:migrate, which has a lot of the
machinery for running migrations. The two are pretty tightly linked.
In fact, what I got to thinking is that by using code:priv_dir(App)
instead of boss_files:root_priv_dir(App), the whole thing could be in
boss_db, and thus be with the rest of the database code.