"The only solution would be to parse the strings the user provides
every time for syntax accuracy".
That is in fact what's being done (or should have been done anyway).
I think way back Wheels simply failed when it was passed something unknown.
It was an ugly failure with usually very cryptic error messages but it
was better than allowing it to go through at least.
On Thu, Dec 29, 2011 at 8:37 PM, Donald Humphreys
<dhumph...@gmail.com> wrote:
> It could possibly be done, although I don't see an obvious solution.
> The original idea I'm sure was to give flexibility in query syntax
> entered by the user. Unfortunately there is no way to tell in the
> model if the where condition was from the programmer or interpolated
> before being passed in. The only solution would be to parse the
> strings the user provides every time for syntax accuracy. In cfrel,
> protection against this problem is a side effect of parsing the
> strings for column mapping. However, this is too complex of a method
> to be implemented in the core at this time. I will have to think more
> about this and how to fix it.
>
> On Thu, Dec 29, 2011 at 2:23 PM, Per Djurner <per.d...@gmail.com> wrote:
>> I think you're right, Don.
>> That's certainly something that needs to be looked at.
>> It should be cfqueryparam or nothing at all in terms of what gets sent
>> to the database adapter.
>>
>> Contact me off list if you need any help with it.
>>
>> / Per
>>
>> On Thu, Dec 29, 2011 at 6:10 PM, Don Humphreys <dhumph...@gmail.com> wrote:
>>> Per,
>>>
>>> It is true that cfqueryparam is used. But isn't it also true that when a non-standard expression is passed, wheels just runs it as is? And strings from the params are always interpolated into where= regardless of their content. This could potentially be a big security hole if all of that is true, since the wheels regex would never match a hack string.
>>>
>>> Don
>>>
>>> Sent from my iPhone
>>>
>>> On Dec 29, 2011, at 8:46 AM, Per Djurner <per.d...@gmail.com> wrote:
>>>
>>>> I guess what I'm not understanding is how that could happen through
>>>> Wheels given that it always uses cfqueryparam.
>>>> Were you able to trace down which type of queries that the attack was made on?
>>>>
>>>> On Thu, Dec 29, 2011 at 2:29 PM, Alfredo Baraldi
>>>> <alfredo...@gmail.com> wrote:
>>>>> Yes, it's true.
>>>>>
>>>>>
>>>>>
>>>>> 2011/12/29 Per Djurner <per.d...@gmail.com>
>>>>>>
>>>>>> I was just referring to your own situation, you said that 10GB had
>>>>>> been destroyed on your server, right?
>>>>>>
>>>>>> On Thu, Dec 29, 2011 at 12:55 PM, Alfredo Baraldi
>>>>>> <alfredo...@gmail.com> wrote:
>>>>>>> I refer to this post:
>>>>>>>
>>>>>>> http://groups.google.com/group/cfwheels/browse_thread/thread/62bdfb483e50c749/f9309fe45fb39c91?hl=en&lnk=gst&q=foundeo
>>>>>>>
>>>>>>> Could I misinterpreted the meaning?
>>>>>>>
>>>>>>> -Alfredo
>>>>>>>
>>>>>>>
>>>>>>> 2011/12/29 Per Djurner <per.d...@gmail.com>
>>>>>>>>
>>>>>>>> "lilupophilupop destroyed 10GB of data on our server MSSQL"
>>>>>>>>
>>>>>>>> Just curious, was that through Wheels?
>>>>>>>>
>>>>>>>> The Wheels ORM uses cfqueryparam which should have protected you :O
>>>>>>>> Maybe it was through Wheels but on normal cfquery tags (with no
>>>>>>>> cfqueryparam)?
>>>>>>>>
>>>>>>>> / Per
>>>>>>>>
>>>>>>>> On Wed, Dec 28, 2011 at 7:05 PM, Alfredo Baraldi
>>>>>>>> <alfredo...@gmail.com> wrote:
>>>>>>>>> Previous Wheels versions from 1.0.6 have been attacked and thanks to
>>>>>>>>> the
>>>>>>>>> advice of Pete of Foundeo the problem seems solved.
>>>>>>>>> For more information
>>>>>>>>> lilupophilupop
>>>>>>>>> http://isc.sans.edu/diary.html?storyid=12127#comment
>>>>>>>>> For this reason, the interest was created, and also because
>>>>>>>>> "lilupophilupop"
>>>>>>>>> has destroyed destroyed 10GB of data on our server MSSQL
>>>>>>>>> -Alfredo
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> 2011/12/28 Yannick <bizon...@gmail.com>
>>>>>>>>>>
>>>>>>>>>> I was wondering why the interest in this product since wheels can
>>>>>>>>>> handle
>>>>>>>>>> the important security issue of sql injection and cross-site
>>>>>>>>>> scripting.
>>>>>>>>>>
>>>>>>>>>> Thanks for sharing your review.
>>>>>>>>>>
>>>>>>>>>> On Wed, Dec 28, 2011 at 1:19 PM, Alfredo Baraldi
>>>>>>>>>> <alfredo...@gmail.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>> I plan to investigate in the next few days, it is a task that I
>>>>>>>>>>> must
>>>>>>>>>>> carry on because I would buy the component. However, the trial
>>>>>>>>>>> version is
>>>>>>>>>>> encrypted and makes it more difficult to interpret. I will take
>>>>>>>>>>> care
>>>>>>>>>>> to
>>>>>>>>>>> inform on progress and if there were new from you let me know
>>>>>>>>>>>
>>>>>>>>>>> -Alfredo
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> You received this message because you are subscribed to the Google
>>>>>>>>>>> Groups
>>>>>>>>>>> "ColdFusion on Wheels" group.
>>>>>>>>>>> To post to this group, send email to cfwh...@googlegroups.com.
>>>>>>>>>>> To unsubscribe from this group, send email to
>>>>>>>>>>> cfwheels+u...@googlegroups.com.
>>>>>>>>>>> For more options, visit this group at
>>>>>>>>>>> http://groups.google.com/group/cfwheels?hl=en.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Yannick Morin
>>>>>>>>>> Co-founder of bizonbytes.com
--
You received this message because you are subscribed to the Google Groups "ColdFusion on Wheels" group.
To post to this group, send email to cfwh...@googlegroups.com.
To unsubscribe from this group, send email to cfwheels+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cfwheels?hl=en.
I plan to investigate in the next few days, it is a task that I must carry on because I would buy the component. However, the trial version is encrypted and makes it more difficult to interpret. I will take care to inform on progress and if there were new from you let me know
-Alfredo
--
You received this message because you are subscribed to the Google Groups "ColdFusion on Wheels" group.
To post to this group, send email to cfwh...@googlegroups.com.
To unsubscribe from this group, send email to cfwheels+u...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/cfwheels?hl=en.
I was wondering why the interest in this product since wheels can handle the important security issue of sql injection and cross-site scripting.
Just curious, was that through Wheels?
The Wheels ORM uses cfqueryparam which should have protected you :O
Maybe it was through Wheels but on normal cfquery tags (with no cfqueryparam)?
/ Per
On Wed, Dec 28, 2011 at 7:05 PM, Alfredo Baraldi
"lilupophilupop destroyed 10GB of data on our server MSSQL"
On Thu, Dec 29, 2011 at 12:55 PM, Alfredo Baraldi
I was just referring to your own situation, you said that 10GB had
On Thu, Dec 29, 2011 at 2:29 PM, Alfredo Baraldi
<cffunction name="sqlSafe" access="public" returntype="string" output="false">
<cfargument name="strVal" required="true">
<cfscript>
var sqlList = "',%";
var replacementList = "'',\%";
return trim(replaceList( strVal , sqlList , replacementList ));
</cfscript>
<cfreturn retStr>
</cffunction>
It is true that cfqueryparam is used. But isn't it also true that when a non-standard expression is passed, wheels just runs it as is? And strings from the params are always interpolated into where= regardless of their content. This could potentially be a big security hole if all of that is true, since the wheels regex would never match a hack string.
Don
Sent from my iPhone
On Dec 29, 2011, at 8:46 AM, Per Djurner <per.d...@gmail.com> wrote:
Contact me off list if you need any help with it.
/ Per
On Thu, Dec 29, 2011 at 6:10 PM, Don Humphreys <dhumph...@gmail.com> wrote: