Re: [framework-one] cfmljure 0.1.0 released!

2 views
Skip to first unread message

corfield.org

unread,
Feb 2, 2015, 3:34:38 AM2/2/15
to framew...@googlegroups.com, cfml...@googlegroups.com
I quietly released cfmljure 0.1.1 this weekend with Andrew's changes included so if you're on ColdFusion you can have a play with this now!

Sean Corfield -- (904) 302-SEAN
An Architect's View -- http://corfield.org/
World Singles, LLC -- http://worldsingles.com/
(sent from my iPhone)

> On Jan 28, 2015, at 09:38, Sean Corfield <se...@corfield.org> wrote:
>
>> On Jan 27, 2015, at 10:11 PM, Andrew Myers <am2...@gmail.com> wrote:
>> I had another look at this, and it turns out the problem was actually that ACF was not maintaining the ordering of the argumentCollection when it was passed into the _call function. It's just another one of the joys of using ACF.
>
> Ah, good to know. And, yes, that sucks too. Changing the signature for _call() is a reasonable change for portability and the rest aren't too horrible either, at this point.
>
> A couple of cleanups before you send a PR:
>
> * pull file separator out to a local fs variable to avoid calling jlSystem.getProperty() in three places
> * ensure all calls use FW/1 house style spacing, i.e., obj.method( arg, arg, arg );
> * change _call() signature to public any function _call( any methodArgs )
>
> Then feel free to send a PR and I'll make sure it all runs on Railo properly (unless you've already done that?).
>
>> I've made some changes that seem to fix it, but the examples are still majorly sucky due to the need to use javaCast (so I put them in a separate file).
>
> Thank you!
>
> Sean Corfield -- (904) 302-SEAN
> An Architect's View -- http://corfield.org/
>
> "Perfection is the enemy of the good."
> -- Gustave Flaubert, French realist novelist (1821-1880)
>
>
>
Reply all
Reply to author
Forward
0 new messages