Pull request

[Jesse Shaffer]

Hey, just out of curiosity - I've had an open pull request for almost a month now... I realize the folks in charge probably have a lot on their plates, but I'm just wondering if anyone has looked at it or if there's something I'm missing in order to to get it merged in?

[Peter Boughton]

The changes to org.cfeclipse.cfml/.settings/org.eclipse.jdt.ui.prefs look odd - are they necessary / relevant to the Interface wizard changes?

Other than that, from a very very quick scan through things I don't see anything that causes alarm (but I am also not at all familiar with the codebase, so would need to defer to Denny on whether or not there's anything not right).

[Jesse Shaffer]

The prefs changes were unintentional party of the commit - I'm using a more recent version of Eclipse (beta).  When I realized it completely changed that file I appended the original settings to the end of it.  It now has the settings (mainly java formatting prefs) that will work on both older and newer versions of Eclipse.  I can replace the contents with what was there before if it's going to be a problem...

The changes to org.cfeclipse.cfml/.settings/org.eclipse.jdt.ui.prefs look odd - are they necessary / relevant to the Interface wizard changes?

Other than that, from a very very quick scan through things I don't see anything that causes alarm (but I am also not at all familiar with the codebase, so would need to defer to Denny on whether or not there's anything not right).

--
You received this message because you are subscribed to a topic in the Google Groups "CFEclipse Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/cfeclipse-dev/YCS4UDEUn-0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to cfeclipse-de...@googlegroups.com.
To post to this group, send email to cfecli...@googlegroups.com.
Visit this group at http://groups.google.com/group/cfeclipse-dev.
For more options, visit https://groups.google.com/d/optout.