--
You received this message because you are subscribed to the Google Groups "Ceres Solver" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ceres-solver...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/84b7604a-1455-4c9a-ae46-985cca090f49n%40googlegroups.com.
--
You received this message because you are subscribed to the Google Groups "Ceres Solver" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ceres-solver...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CABqdRUD1nJDFSGPpFLfQN%2BYMmcXmHt1Q4i4E9FESN9Gi_hLLgw%40mail.gmail.com.
Hi Sameer,Thank you for all your great work!I've played around with manifolds and some AutoDiffCostFunctions over the past few days, and it all worked great so far under Windows with VS2022.I've just very briefly tried compiling Ceres under a few different CMAKE_CXX_STANDARD modes, and a few things came up.
It was all a bit in a rush, as I am leaving for a one-week seminar abroad - I might not have time to follow any of this up next week but I still quickly wanted to post it, and I can try my best next week to reply if needed.First, one small observation: I noticed that there are no additional CMake targets when building with BUILD_BENCHMARKS=ON. Is that expected? (i.e. there seem to be no benchmark targets whatsoever)
Next, I compiled with CMAKE_CXX_STANDARD=17, Ceres itself and the examples compiled fine, but some of the tests give the following compiler error:I think one of them is internal/ceres/CMakeFiles/jet_test.dir/jet_test.cc.obj. Most of the tests do seem to compile without error.I haven't actually run the tests that did compile as I ran out of time, but I can try to do that next week or the week after if it helps.
I will be using the C++17 and C++20 modes going forward.Next, with CMAKE_CXX_STANDARD=20, Ceres & examples compile fine again but gmock has issues. I guess it's not really an issue for using Ceres, but longer-term it would probably be good to have tests running on Windows in C++20 mode.
Finally, just to complete this test parcour, it all compiles fine with -DCMAKE_CXX_STANDARD=14, which I think might be the default that CMake (or Ceres) chooses
(otherwise I wouldn't have been able to run all the tests successfully last week).
If there's anything else you can think of that should be tested under Windows, I'd be happy to try. I won't be able to test CxSparse or SuiteSparse though, that's a configuration I currently don't use.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CAD7zOaTe2f0%3DCJwYMMphbHkGmzZ3-V0b7v2x-xhJmB-80pkuXA%40mail.gmail.com.
(Also, I am really impressed that there wasn't a single compile error in Ceres itself or the examples, in any of the modes! That's really a bit of a miracle - or,
really impressive work and testing by you guys, and also from the MSVC compiler, which by now looks to be impressively standard-compliant.
Maybe one more thing I could test is compilation with /permissive- flag.)
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CAD7zOaQExKfJ2k8vSKhNicr60TtR4FmvL5OHBqAvGDx6Jhu0-g%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CAD7zOaTe2f0%3DCJwYMMphbHkGmzZ3-V0b7v2x-xhJmB-80pkuXA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CAD7zOaTe2f0%3DCJwYMMphbHkGmzZ3-V0b7v2x-xhJmB-80pkuXA%40mail.gmail.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/CALjVmNckjifTOVfEnKkN84AoDH4mjgf97hqPtfzZBbwP_%2BGXCQ%40mail.gmail.com.