Hi, I compiled the master branch of ceres-solver with the current master branch of eigen.
And I get this warning:
```
../3rd/ceres-solver/internal/ceres/covariance_impl.cc: In member function ‘bool ceres::internal::CovarianceImpl::ComputeCovarianceValuesUsingDenseSVD()’:
../3rd/ceres-solver/internal/ceres/covariance_impl.cc:727:70: warning: ‘Eigen::BDCSVD<MatrixType, Options>::BDCSVD(const MatrixType&, unsigned int) [with MatrixType_ = Eigen::Matrix<double, -1, -1, 1>; int Options_ = 0; MatrixType = Eigen::Matrix<double, -1, -1, 1>]’ is deprecated [-Wdeprecated-declarations]
727 | Eigen::ComputeThinU | Eigen::ComputeThinV);
| ^
In file included from ../3rd/eigen/Eigen/SVD:40,
from ../3rd/ceres-solver/internal/ceres/covariance_impl.cc:42:
../3rd/eigen/Eigen/src/SVD/BDCSVD.h:202:20: note: declared here
202 | EIGEN_DEPRECATED BDCSVD(const MatrixType& matrix, unsigned int computationOptions) : m_algoswap(16), m_numIters(0) {
|
```
Then I check the deprecated list of eigen.
link:
https://eigen.tuxfamily.org/dox/deprecated.htmlCurrent usage of BDCSVD constructor is deprecated and will be removed in the next major eigen version.
Code under `internal/ceres/covariance_impl.cc line:726`
```
Eigen::BDCSVD<Matrix> svd(dense_jacobian,
Eigen::ComputeThinU | Eigen::ComputeThinV);
```
should be changed to
```
Eigen::BDCSVD<Matrix, Eigen::ComputeThinU | Eigen::ComputeThinV> svd(
dense_jacobian);
```
I would like to open a pull request on GitHub for this. Do you have any suggestions?