Is this a math bug?

[Julius Ziegler]

This is from tiny-solver.h, and if I understand the code correctly the code does not do what the formula in the comment says. The "norm" should be "sqnorm" to match the formula.

// On the first iteration, compute a diagonal (Jacobi) scaling
// matrix, which we store as a vector.
if (summary.iterations == 0) {
   // jacobi_scaling = 1 / (1 + diagonal(J'J))
   //
   // 1 is added to the denominator to regularize small diagonal
   // entries.
   jacobi_scaling_ = 1.0 / (1.0 + jacobian_.colwise().norm().array());
}

[Sameer Agarwal]

This looks like a bug in the comment.

--
You received this message because you are subscribed to the Google Groups "Ceres Solver" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ceres-solver...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ceres-solver/fde5838c-9fd2-4a6b-b788-dadd9d270d7fn%40googlegroups.com.