[Merge] lp:~nicolas-rebagliati/cdpedia/warn_missing_commands into lp:cdpedia

9 views
Skip to first unread message

aenima

unread,
May 25, 2014, 7:41:22 PM5/25/14
to mp+2...@code.launchpad.net, Facundo Batista
aenima has proposed merging lp:~nicolas-rebagliati/cdpedia/warn_missing_commands into lp:cdpedia.

Requested reviews:
Facundo Batista (facundo)

For more details, see:
https://code.launchpad.net/~nicolas-rebagliati/cdpedia/warn_missing_commands/+merge/220893

lanza un marning si ionice no esta instalado, y si no pede enerar la iso (porque no esta instalado el mkisofs) lanza un critical y corta la ejecucio
--
https://code.launchpad.net/~nicolas-rebagliati/cdpedia/warn_missing_commands/+merge/220893
Your team CDPedistas is subscribed to branch lp:cdpedia.
review-diff.txt

Facundo Batista

unread,
May 31, 2014, 2:16:53 AM5/31/14
to aenima
Review: Needs Fixing

Very nice!! Sorry for the delay getting to review this...

A couple of comments:

- the logged messages should be in English (yes, half of the stuff is still in Spanish,
we are in the process of fixing that)

- you should not use after column 79, as specified in PEP 8

- you should include the error message of the exception just happened

Thanks!!!

nor...@launchpad.net

unread,
Jun 2, 2014, 10:11:09 AM6/2/14
to mp+2...@code.launchpad.net, Facundo Batista
The proposal to merge lp:~nicolas-rebagliati/cdpedia/warn_missing_commands into lp:cdpedia has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~nicolas-rebagliati/cdpedia/warn_missing_commands/+merge/220893
Reply all
Reply to author
Forward
0 new messages