DeltaSpike - which versions to support by cdi-unit?

33 views

Skip to first unread message

Illya Kysil

unread,

May 11, 2020, 6:16:23 PM5/11/20

to CDI-Unit

Hi,

I'm investigating the issue about the usage of the newer versions of DeltaSpike with the cdi-unit 4.1+.

It looks like the versions of DeltaSpike fall into 3 sets which require incompatible changes to the cdi-unit codebase:

* pre 1.7.0 (current implementation);

* 1.7.x and 1.8.x;

* 1.9.x.

See https://github.com/cdi-unit/cdi-unit/issues/100#issuecomment-626988126 for details.

Is it useful to support multiple incompatible versions of the DeltaSpike?

Is the latest version (1.9.3 at the moment) enough?

Thank you for any input.

Illya Kysil

unread,

May 13, 2020, 12:51:03 PM5/13/20

to CDI-Unit

It looks like there is a way to implement support for all versions of DeltaSpike without resorting to a per-version module and dependency in cdi-unit.

But I don't want to add dynamic discovery into the already existing discovery mechanism in WeldTestUrlDeployment.

It is proposed to refactor the class discovery mechanism in WeldTestUrlDeployment to make it modular.

The new mechanism will rely on the JDK's ServiceLoader.

I will proceed with a PR - a preview is available at https://github.com/ikysil/cdi-unit/pull/4.