[SyneRBI/SIRF] Creating compatible ImageData from AcquisitionData and voxels grid dimensions x and y (PR #1364)
Evgueni Ovtchinnikov
Changes in this pull request
Implements an alternative way to create a STIRImageData object from AcquisitionData object suggested by @ashgillman that makes the created image data object compatible with the acquisition data object it is created from.
Testing performed
Related issues
This PR takes over from PR #231.
Checklist before requesting a review
- I have performed a self-review of my code
- I have added docstrings/doxygen in line with the guidance in the developer guide
- I have implemented unit tests that cover any new or modified functionality
- The code builds and runs on my machine
- CHANGES.md has been updated with any functionality change
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following:
- The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.
You can view, comment on, or merge this pull request online at:
https://github.com/SyneRBI/SIRF/pull/1364
Commit Summary
- d95c7bb updated files for release 3.9.0 [ci skip]
- 54505e7 Merge branch 'master' of https://github.com/SyneRBI/SIRF
- dedf83c Merged branch 'master' of https://github.com/SyneRBI/SIRF
- a164114 added numpy array to possible SIRF image data algebra operands
- c53d80b added to User Guide a subsection on SIRF/numpy data algebra peculiarities [ci skip]
- 9f2ecf8 updated CHANGES.md [ci skip]
- 80b3c07 added tests for #1358
- 57d9e15 attended to Codacy issues
- 0477cc0 simpliied mixed data algebra
- 11d9e9c adoppted Ash Gillman's version of cSTIR_imageFromAcquisitionDataAndNxNy
- 96ea4b5 added testing xy argument of sirf.STIR.AcquisitionData.create_iniform_image
- 4fb8ea8 updated CHANGES.md [ci skip]
File Changes
(8 files)
- M CHANGES.md (8)
- M doc/UserGuide.md (4)
- M src/Registration/pReg/Reg.py (59)
- M src/common/SIRF.py (14)
- M src/common/Utilities.py (29)
- M src/xSTIR/cSTIR/cstir.cpp (21)
- M src/xSTIR/cSTIR/include/sirf/STIR/stir_data_containers.h (7)
- M src/xSTIR/pSTIR/tests/tests_four.py (5)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- c1002eb removed code that belongs to mixed-data-alg-qfix
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- 5b9677c attended to Codacy issue
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
@KrisThielemans requested changes on this pull request.
In CHANGES.md:
> @@ -1,5 +1,10 @@ # ChangeLog +## v3.9.1 + +* SIRF/STIR + - The implementation of the creation of sir.STIR.ImageData from sirf.STIR.AcquisitionData has been revised to ensure compatibility of ImageData dimensions and voxel sizes with AcquisitionData.⬇️ Suggested change
- - The implementation of the creation of sir.STIR.ImageData from sirf.STIR.AcquisitionData has been revised to ensure compatibility of ImageData dimensions and voxel sizes with AcquisitionData. + - The implementation of the creation of `sirf.STIR.ImageData` from `sirf.STIR.AcquisitionData` has been revised to ensure compatibility of `ImageData` dimensions and voxel sizes with `AcquisitionData`.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
@KrisThielemans pushed 1 commit.
- f8d0667 Update CHANGES.md
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
@KrisThielemans approved this pull request.
@evgueni-ovtchinnikov , please merge master on here for conflicts (probably just in the README). Feel free to squash-merge then (do edit the suggested commit message to remove everything that is irrelevant).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
@evgueni-ovtchinnikov pushed 1 commit.
- bb886b5 Merge branch 'master' into id-from-ad-nxny
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Evgueni Ovtchinnikov
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.