[SyneRBI/SIRF-SuperBuild] CIL & deps: move to conda (PR #994)
Casper da Costa-Luis
- move CIL & deps from CMake to conda
cil,ccpi-regulariser,astra-toolbox,tomophantom,tigre
- related: #978
You can view, comment on, or merge this pull request online at:
https://github.com/SyneRBI/SIRF-SuperBuild/pull/994
Commit Summary
- 4cb959c CIL & deps: move to conda
File Changes
(10 files)
- M .github/workflows/c-cpp.yml (40)
- M Dockerfile (8)
- M SuperBuild.cmake (14)
- M VirtualBox/scripts/UPDATE_functions.sh (1)
- M VirtualBox/scripts/update_VM_to_full_CIL.sh (7)
- M docker/compose.sh (2)
- M docker/docker-compose.devel.yml (2)
- M docker/docker-compose.gpu.yml (2)
- M docker/requirements.yml (20)
- M version_config.cmake (35)
Patch Links:
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/994.patch
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/994.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- 32d5e74 CIL & deps: move to conda
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- 651f49b CIL & deps: move to conda
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- e93ebed CIL & deps: move to conda
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 0 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl pushed 1 commit.
- 5425fdc CIL optional deps: move to conda
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino commented on this pull request.
In .github/workflows/c-cpp.yml:
> @@ -162,12 +156,8 @@ jobs:
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
export superbuild=`pwd`
export BUILD_FLAGS="-DCMAKE_INSTALL_PREFIX=~/install -DPYVER=3 -DUSE_SYSTEM_RocksDB=OFF -DBUILD_TESTING_Gadgetron:BOOL=ON"
⬇️ Suggested change
- export BUILD_FLAGS="-DCMAKE_INSTALL_PREFIX=~/install -DPYVER=3 -DUSE_SYSTEM_RocksDB=OFF -DBUILD_TESTING_Gadgetron:BOOL=ON" + export BUILD_FLAGS="-DCMAKE_INSTALL_PREFIX=~/install -DPYVER=3 -DUSE_SYSTEM_RocksDB=OFF -DBUILD_TESTING_Gadgetron:BOOL=ON -DSTIR_DISABLE_HDF5:BOOL=OFF"
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
@KrisThielemans commented on this pull request.
In .github/workflows/c-cpp.yml:
> @@ -162,12 +156,8 @@ jobs:
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
export superbuild=`pwd`
export BUILD_FLAGS="-DCMAKE_INSTALL_PREFIX=~/install -DPYVER=3 -DUSE_SYSTEM_RocksDB=OFF -DBUILD_TESTING_Gadgetron:BOOL=ON"
we/Gadgetron no longer need rocksDB. are we still building it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino commented on this pull request.
In .github/workflows/c-cpp.yml:
> @@ -162,12 +156,8 @@ jobs:
export PATH="/usr/lib/ccache:/usr/local/opt/ccache/libexec:$PATH"
export superbuild=`pwd`
export BUILD_FLAGS="-DCMAKE_INSTALL_PREFIX=~/install -DPYVER=3 -DUSE_SYSTEM_RocksDB=OFF -DBUILD_TESTING_Gadgetron:BOOL=ON"
It doesn't look like so
https://github.com/SyneRBI/SIRF-SuperBuild/blob/5425fdc0d954b61dc51c85f18dc3bcab0ffde704/SuperBuild.cmake#L295-L296
Gadgetron seems to be only dependent on mrd-storage-server
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- cb6e216 disable HDF5 STIR support
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- 688901e Update SIRF tag to version v3.10.0
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino commented on this pull request.
> @@ -144,7 +136,7 @@ set(DEFAULT_STIR_TAG rel_6.3.0) ## SIRF set(DEFAULT_SIRF_URL https://github.com/SyneRBI/SIRF) -set(DEFAULT_SIRF_TAG "4198e7f17ef17ff8b1913e20d1db3e7c9383d4da") # 2026-03-12 +set(DEFAULT_SIRF_TAG "v3.10.0") # 2026-03-12⬇️ Suggested change
-set(DEFAULT_SIRF_TAG "v3.10.0") # 2026-03-12 +set(DEFAULT_SIRF_TAG "move_MR_test")
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- a534cbf Update SIRF hash
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- 575ca86 force USE_SYSTEM_HDF5=OFF on CI workflow
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.