[SyneRBI/SIRF] Python: modify some DataContainer methods to fall back to numpy (Issue #1334)

Kris Thielemans

unread,

Jul 24, 2025, 9:45:31 AM7/24/25

to SyneRBI/SIRF, Subscribed

KrisThielemans created an issue (SyneRBI/SIRF#1334)

I suggest to modify
https://github.com/SyneRBI/SIRF/blob/8fbfe5294e4efd57d12ae15d87b97f64e96d09d4/src/common/SIRF.py#L268-L276
to something like this

def norm(self):
   if (self.supports_array_view):
      return numpy.linalg.norm(self.asarray())
   # original code

@evgueni-ovtchinnikov @casperdcl good idea?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Casper da Costa-Luis

unread,

Jul 24, 2025, 10:17:57 AM7/24/25

to SyneRBI/SIRF, Subscribed

casperdcl left a comment (SyneRBI/SIRF#1334)

Yes, though as @ckolbPTB mentioned there may be cases where self.norm() should not be calculated over the whole self.asarray() 🤷.

Also related: #1332 (review)

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kris Thielemans

unread,

Jul 24, 2025, 11:50:20 AM7/24/25

to SyneRBI/SIRF, Subscribed

KrisThielemans left a comment (SyneRBI/SIRF#1334)

Yes, though as @ckolbPTB mentioned there may be cases where self.norm() should not be calculated over the whole self.asarray() 🤷.

sure, but I don't think that's we should worry about this here. The current norm() would then be inappropriate already anyway.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Evgueni Ovtchinnikov

unread,

Jul 24, 2025, 11:55:57 AM7/24/25

to SyneRBI/SIRF, Subscribed

evgueni-ovtchinnikov left a comment (SyneRBI/SIRF#1334)

@KrisThielemans I am afraid your suggestion will only work for DataContainer objects, but views may be numpy arrays.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Evgueni Ovtchinnikov

unread,

Jul 24, 2025, 12:10:18 PM7/24/25

to SyneRBI/SIRF, Subscribed

evgueni-ovtchinnikov left a comment (SyneRBI/SIRF#1334)

re Christoph remark: if he meant ignoring some acquisitions then this is already covered by the ignore mask, but it is easy to extend this feature to any subset by adding optional list argument in the constructor of AcquisitionDataView - will ask him next time we meet.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Edoardo Pasca

unread,

Feb 5, 2026, 5:34:55 AMFeb 5

to SyneRBI/SIRF, Subscribed

Closed #1334 as completed.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward