[SyneRBI/SIRF] Update ch2sirf with SIRF master (PR #1262)

0 views
Skip to first unread message

Edoardo Pasca

unread,
Jun 6, 2024, 9:40:10 AMJun 6
to SyneRBI/SIRF, Subscribed

Changes in this pull request

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

You can view, comment on, or merge this pull request online at:

  https://github.com/SyneRBI/SIRF/pull/1262

Commit Summary

  • 1d53570 Added optional argument out in all gradient-computing methods (#1246)
  • d54c455 sapyb to return even if out is not None (#1254)
  • 1cccaa5 updated data submodule
  • 12949b4 Computing Hessian products with image data objects and related stuff (#1253)
  • 9690feb Merge pull request #1256 from SyneRBI/update-data
  • 6c8e470 V3.7.0 prep (#1258)
  • 63be16b updated version number in CMakeLists.txt and docs [ci skip]
  • f82b1fe [CMAKE] set CMP0074 policy to NEW (honour <packagename>_ROOT)
  • 6c7259d Merge pull request #1261 from KrisThielemans/CMAKE_package_ROOT
  • afca1ca Merge remote-tracking branch 'origin/master' into ch2sirf_update

File Changes

(16 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1262@github.com>

Evgueni Ovtchinnikov

unread,
Jun 6, 2024, 11:04:44 AMJun 6
to SyneRBI/SIRF, Subscribed

@evgueni-ovtchinnikov commented on this pull request.

superseded by just merged #1241


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1262/review/2102254621@github.com>

Kris Thielemans

unread,
Jun 6, 2024, 11:31:51 AMJun 6
to SyneRBI/SIRF, Subscribed

Closed #1262.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1262/issue_event/13068678807@github.com>

Kris Thielemans

unread,
Jun 6, 2024, 11:32:13 AMJun 6
to SyneRBI/SIRF, Subscribed

we'll revert #1241 anyway.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1262/c2152825243@github.com>

Reply all
Reply to author
Forward
0 new messages