[SyneRBI/SIRF] Fix STIR.AcquisitionModel base (missing `__del__`). (PR #1387)

0 views
Skip to first unread message

Evgueni Ovtchinnikov

unread,
Mar 25, 2026, 10:16:48 AM (13 days ago) Mar 25
to SyneRBI/SIRF, Subscribed

Changes in this pull request

Testing performed

Related issues

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • The code builds and runs on my machine
  • CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

You can view, comment on, or merge this pull request online at:

  https://github.com/SyneRBI/SIRF/pull/1387

Commit Summary

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1387@github.com>

Kris Thielemans

unread,
Mar 25, 2026, 10:55:19 AM (13 days ago) Mar 25
to SyneRBI/SIRF, Subscribed

@KrisThielemans approved this pull request.

Hi

can you add a line to CHANGES.md. Please squash-merge then (editing the suggested message). In the future, you probably need to start from a fresh checkout to avoid the multiple merge commits.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1387/review/4007327283@github.com>

Evgueni Ovtchinnikov

unread,
Mar 25, 2026, 11:49:01 AM (13 days ago) Mar 25
to SyneRBI/SIRF, Push

@evgueni-ovtchinnikov pushed 1 commit.

  • 74c1376 [ci skip] updated CHANGES.md


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1387/before/71791248e321a45e2f3a2cf009e2e269471a6faf/after/74c13764e2ddc733ef3cacb6db23d6e7df9698e9@github.com>

Evgueni Ovtchinnikov

unread,
Mar 25, 2026, 11:50:10 AM (13 days ago) Mar 25
to SyneRBI/SIRF, Subscribed

Merged #1387 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1387/issue_event/23897086520@github.com>

Reply all
Reply to author
Forward
0 new messages