[SyneRBI/SIRF-Contribs] LBFGSBPC callbacks (PR #27)

Kris Thielemans

unread,

Jan 8, 2026, 10:02:46 AMJan 8

to SyneRBI/SIRF-Contribs, Subscribed

write objectives.csv whenever it is computed
add support for CIL-style callback (fixes #24 )

You can view, comment on, or merge this pull request online at:

https://github.com/SyneRBI/SIRF-Contribs/pull/27

Commit Summary

03399a4 LBFGSBPC callback: write objectives.csv
f95ad14 LBFGSBPC: add CIL-style callback hook

File Changes

(1 file)

M src/Python/sirf/contrib/LBFGSBPC/LBFGSBPC.py (29)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Kris Thielemans

unread,

Jan 8, 2026, 10:03:07 AMJan 8

to SyneRBI/SIRF-Contribs, Subscribed

KrisThielemans left a comment (SyneRBI/SIRF-Contribs#27)

@MargaretDuff what do you think about the CIL-callback support that I put in?

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Margaret Duff

unread,

Jan 8, 2026, 10:25:30 AMJan 8

to SyneRBI/SIRF-Contribs, Subscribed

MargaretDuff left a comment (SyneRBI/SIRF-Contribs#27)

@MargaretDuff what do you think about the CIL-callback support that I put in?

Thanks @KrisThielemans - I think it looks ok. I haven't run anything but with this in callback

        if self.callbacks is not None:
            for callback in self.callbacks:
                callback(self)

and self.callbacks=callbacks, self.callback(precond_init) and passing self.callback to fmin_l_bfgs_b, it looks like it should work for CIL callbacks. I would want to test the scipy optimiser calling the CIL callback successfully.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kris Thielemans

unread,

Jan 8, 2026, 10:38:28 AMJan 8

to SyneRBI/SIRF-Contribs, Subscribed

KrisThielemans left a comment (SyneRBI/SIRF-Contribs#27)

I would want to test the scipy optimiser calling the CIL callback successfully.

feel free :-)

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kris Thielemans

unread,

Jan 25, 2026, 7:12:27 AMJan 25

to SyneRBI/SIRF-Contribs, Subscribed

KrisThielemans left a comment (SyneRBI/SIRF-Contribs#27)

As nobody has the time to check the CIL calbacks, I'm going to merge this. Feel free to create an issue or fix any problems.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Kris Thielemans

unread,

Jan 25, 2026, 7:12:43 AMJan 25

to SyneRBI/SIRF-Contribs, Subscribed

Merged #27 into master.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward