[SyneRBI/SIRF-SuperBuild] SIRF CMake improvements (PR #976)
Kris Thielemans
- adding
SIRF_DISABLE_Gadgetron_toolboxesmakes it easier for the user to disable this if there are compilation problems - prevent adding SIRF options and dependencies when
USE_SYSTEM_SIRF==ON
(Note: sits on top of #973 and #975, although it's independent, so let's merge those first, or if not, we rebase this on current master).
You can view, comment on, or merge this pull request online at:
https://github.com/SyneRBI/SIRF-SuperBuild/pull/976
Commit Summary
- d35bd2c find C and CXX COMPONENTS for (system) HDF5
- ad1edf1 [CI] use ninja
- aceacb6 Fix HDF5 version restriction
- f4a3fe2 pass DISABLE_CUDA to dependent projects
- eb915b1 add SIRF_DISABLE_Gadgetron_toolboxes flag and minor improvements
File Changes
(7 files)
- M .github/workflows/c-cpp.yml (6)
- M CHANGES.md (2)
- M SuperBuild/External_HDF5.cmake (9)
- M SuperBuild/External_SIRF.cmake (45)
- M SuperBuild/External_STIR.cmake (1)
- M SuperBuild/External_parallelproj.cmake (1)
- M version_config.cmake (4)
Patch Links:
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/976.patch
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/976.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
KrisThielemans left a comment (SyneRBI/SIRF-SuperBuild#976)I expect the same docker and run-time failure as in #973 but no other.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
Merged #976 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.