[SyneRBI/SIRF-SuperBuild] update CIL branch for testing (PR #989)
Edoardo Pasca
Changes in this pull request
- fixes #987
Testing performed
Related issues
Checklist before requesting a review
- I have performed a self-review of my code
- I have added docstrings/doxygen in line with the guidance in the developer guide
- I have implemented unit tests that cover any new or modified functionality
- The code builds and runs on my machine
- CHANGES.md has been updated with any functionality change
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following:
- The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF-SuperBuild (the Work) under the terms and conditions of the Apache-2.0 License.
You can view, comment on, or merge this pull request online at:
https://github.com/SyneRBI/SIRF-SuperBuild/pull/989
Commit Summary
- b9d97b7 update CIL branch for testing
File Changes
(1 file)
- M version_config.cmake (4)
Patch Links:
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/989.patch
- https://github.com/SyneRBI/SIRF-SuperBuild/pull/989.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- ca3a06c cat the gadgetron log in case of ctest failure
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 2 commits.
- 9978261 Add RUNPATH to libismrmrd
- ea18092 Merge pull request #6 from wjp/paskino_fix-sirf-cil-unittests
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- ffdc2fe CIL devel build is from this branch
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
paskino left a comment (SyneRBI/SIRF-SuperBuild#989)The residual error in the DEVEL_BUILD is TORCH_TEST_PYTHON
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
KrisThielemans left a comment (SyneRBI/SIRF-SuperBuild#989)It's strange that we don't get any output that says what the failure. we just have
CoverageWarning: Module sirf.torch was never imported. (module-not-imported);
but that could be irrelevant, as the coverage stuff is broken since a few years.
On the other hand, this is the DEVEL_BUILD=OFF build (with g++11), while all others are fine. So, I wonder if we shouldn't be updating the SIRF_TAG.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
paskino left a comment (SyneRBI/SIRF-SuperBuild#989)No, that's the DEVEL_BUILD=ON
So currently
DEVEL_BUILD |
TAG |
|---|---|
OFF |
SyneRBI/SIRF@11a6a50 |
ON |
master |
This means that only the DEVEL_BUILD=ON runs unit tests with PyTorch.
It also means that we need to change the SIRF_TAG to nearly master, or whatever commit we want to tag as v3.10.0.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- deced26 upgrade SIRF to before #1305
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Kris Thielemans
KrisThielemans left a comment (SyneRBI/SIRF-SuperBuild#989)That's what I meant... Good luck!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 3 commits.
- dfc8352 revert to using CIL numpy-2 branch
- ded137e revert add cat of gadgetron log
- 8e1dd67 add to changes
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl commented on this pull request.
> + # TODO fix PyTorch unittest + # set (DEFAULT_SIRF_TAG origin/master)⬇️ Suggested change
- # TODO fix PyTorch unittest - # set (DEFAULT_SIRF_TAG origin/master) + set (DEFAULT_SIRF_TAG origin/master)
> @@ -162,6 +162,7 @@ set(DEFAULT_JSON_URL https://github.com/nlohmann/json) set(DEFAULT_JSON_TAG v3.11.3) # CCPi CIL +# test different branch of CIL to test fix⬇️ Suggested change
-# test different branch of CIL to test fix
In CHANGES.md:
> @@ -1,8 +1,11 @@ # ChangeLog ## v3.X.x +- CMake: + - Patch ISMRMRD CMakeLists.txt to set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE) (#)⬇️ Suggested change
- - Patch ISMRMRD CMakeLists.txt to set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE) (#) + - Patch ISMRMRD `CMAKE_INSTALL_RPATH_USE_LINK_PATH` (#991)
In CHANGES.md:
> - Updated versions: - SIRF-Contribs: v3.9.1 + - SIRF: 4198e7f17ef17ff8b1913e20d1db3e7c9383d4da both for default and devel #2026-03-12⬇️ Suggested change
- - SIRF: 4198e7f17ef17ff8b1913e20d1db3e7c9383d4da both for default and devel #2026-03-12 + - SIRF: 4198e7f17ef17ff8b1913e20d1db3e7c9383d4da (2026-03-12)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
@paskino pushed 1 commit.
- 9598983 Apply suggestions from code review
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl commented on this pull request.
> + # TODO fix PyTorch unittest + # set (DEFAULT_SIRF_TAG origin/master)
@paskino this causes a unittest fail though. I suppose we should merge anyway and tackle #992 separately?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Casper da Costa-Luis
@casperdcl approved this pull request.
we'll tackle #992 separately
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Edoardo Pasca
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.