[SyneRBI/SIRF] Revert "Moving SyneRBI-Challenge nema-data utilities to SIRF (#1241)" (PR #1263)

0 views
Skip to first unread message

Kris Thielemans

unread,
Jun 6, 2024, 11:28:40 AMJun 6
to SyneRBI/SIRF, Subscribed

This reverts commit b90383e.


You can view, comment on, or merge this pull request online at:

  https://github.com/SyneRBI/SIRF/pull/1263

Commit Summary

  • 8cca58d Revert "Moving SyneRBI-Challenge nema-data utilities to SIRF (#1241)"

File Changes

(9 files)

Patch Links:


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1263@github.com>

Evgueni Ovtchinnikov

unread,
Jun 6, 2024, 12:05:07 PMJun 6
to SyneRBI/SIRF, Subscribed

@evgueni-ovtchinnikov approved this pull request.

I do not mind reverting if what I have done is not good enough, but I am afraid I am completely lost now. If randoms cannot be computed for SPECT data, we need a method that computes prompts only, do we not? BTW is there a way to find out whether one has PET or SPECT data?


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1263/review/2102402989@github.com>

Kris Thielemans

unread,
Jun 6, 2024, 2:02:09 PMJun 6
to SyneRBI/SIRF, Subscribed

If randoms cannot be computed for SPECT data, we need a method that computes prompts only, do we not?

sure, but we have one already, i.e. the set_input, process(), get_output().

BTW is there a way to find out whether one has PET or SPECT data?

You have to get into stir::ExamInfo::imaging_modality. We don't expose any of that to SIRF, and will have to.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1263/c2153105465@github.com>

Kris Thielemans

unread,
Jun 6, 2024, 2:02:22 PMJun 6
to SyneRBI/SIRF, Subscribed

Merged #1263 into master.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <SyneRBI/SIRF/pull/1263/issue_event/13070453340@github.com>

Reply all
Reply to author
Forward
0 new messages