CCNET 1.4 issue with MSBuild task

[robford123]

I recently upgraded to 1.4.0.3325 from 1.3.0.2918 and ran into an
issue with the msbuild task.

We were getting this error when building

</msbuild>MSBUILD : error MSB1021: Cannot create an instance of the
logger. Could not load file or assembly
'ThoughtWorks.CruiseControl.MsBuild.XmlLogger\,E:\\Program Files\
\CruiseControl.NET\\server\\ThoughtWorks.CruiseControl.MsBuild.dll' or
one of its dependencies. The given assembly name or codebase was
invalid. (Exception from HRESULT: 0x80131047)
Switch: ThoughtWorks.CruiseControl.MsBuild.XmlLogger,E:\Program Files
\CruiseControl.NET\server\ThoughtWorks.CruiseControl.MsBuild.dll;e:
\Program Files\CruiseControl.NET\server\Empower.NET\Artifacts\msbuild-
results.xml
</build>
</cruisecontrol>

We had to change our syntax slightly from

<logger>ThoughtWorks.CruiseControl.MsBuild.XmlLogger,E:
\Program Files\CruiseControl.NET\server
\ThoughtWorks.CruiseControl.MsBuild.dll</logger>
</msbuild>

to

<logger>E:\Program Files\CruiseControl.NET\server
\ThoughtWorks.CruiseControl.MsBuild.dll</logger>
</msbuild>

Regards

Rob

[Daniel Hommel]

robford123 wrote:
> We were getting this error when building
>
> </msbuild>MSBUILD : error MSB1021: Cannot create an instance of the
> logger. Could not load file or assembly
> 'ThoughtWorks.CruiseControl.MsBuild.XmlLogger\,E:\\Program Files\
> \CruiseControl.NET\\server\\ThoughtWorks.CruiseControl.MsBuild.dll' or
> one of its dependencies.
>

> We had to change our syntax slightly from
>
> <logger>ThoughtWorks.CruiseControl.MsBuild.XmlLogger,E:
> \Program Files\CruiseControl.NET\server
> \ThoughtWorks.CruiseControl.MsBuild.dll</logger>
> </msbuild>
>
> to
>
> <logger>E:\Program Files\CruiseControl.NET\server
> \ThoughtWorks.CruiseControl.MsBuild.dll</logger>
> </msbuild>

Seems like i forgot that one can specify multiple logger assemblies when
i tried to fix the quoting issues in the MSBuild task. I'll give it
another review...

Two simple workarounds:
1. Only specify the assembly you're actually using
2. Don't put the assemblies in a directory containing spaces so the
logger property won't get quoted (not really certain about this but it
*should* work)

I hope i can fix that for the final 1.4 release.

regards,

Daniel