SF.net SVN: ccnet:[7321] trunk/project/core/IntegrationQueueManager.cs

[dna...@users.sourceforge.net]

Revision: 7321
http://ccnet.svn.sourceforge.net/ccnet/?rev=7321&view=rev
Author: dnauck
Date: 2010-05-28 10:19:34 +0000 (Fri, 28 May 2010)

Log Message:
-----------
CCNET-1884: ArgumentNullException in ThoughtWorks.CruiseControl.Core.ProjectIntegratorList.get_Item(String projectName) spamms log file

* guard against null or empty keys, just throw a ProjectNotFoundException (as expected by the caller)

Modified Paths:
--------------
trunk/project/core/IntegrationQueueManager.cs

Modified: trunk/project/core/IntegrationQueueManager.cs
===================================================================
--- trunk/project/core/IntegrationQueueManager.cs 2010-05-28 10:08:56 UTC (rev 7320)
+++ trunk/project/core/IntegrationQueueManager.cs 2010-05-28 10:19:34 UTC (rev 7321)
@@ -87,8 +87,14 @@

public IProjectIntegrator GetIntegrator(string projectName)
{
+ if (string.IsNullOrEmpty(projectName))
+ throw new NoSuchProjectException(projectName);
+
IProjectIntegrator integrator = projectIntegrators[projectName];
- if (integrator == null) throw new NoSuchProjectException(projectName);
+
+ if (integrator == null)
+ throw new NoSuchProjectException(projectName);
+
return integrator;
}

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.